also reset quickfix state when mode stays the same, fixes microsoft#14141

jrieken · jrieken · commit ab404bdf3dbe · 2016-10-28T17:57:32.000+02:00
diff --git a/src/vs/editor/contrib/quickFix/browser/quickFixModel.ts b/src/vs/editor/contrib/quickFix/browser/quickFixModel.ts
@@ -130,17 +130,17 @@ export class QuickFixModel {
 	}
 
 	private _update(): void {
-		dispose(this._quickFixOracle);
+
+		if (this._quickFixOracle) {
+			dispose(this._quickFixOracle);
+			this._onDidChangeFixes.fire(undefined);
+		}
 
 		if (this._editor.getModel()
 			&& CodeActionProviderRegistry.has(this._editor.getModel())
 			&& !this._editor.getConfiguration().readOnly) {
 
 			this._quickFixOracle = new QuickFixOracle(this._editor, this._markerService, p => this._onDidChangeFixes.fire(p));
-
-		} else {
-			// signal unavailable
-			this._onDidChangeFixes.fire(undefined);
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -130,17 +130,17 @@ export class QuickFixModel {`
`130`	`130`	`}`
`131`	`131`
`132`	`132`	`private _update(): void {`
`133`		`- dispose(this._quickFixOracle);`
	`133`	`+`
	`134`	`+ if (this._quickFixOracle) {`
	`135`	`+ dispose(this._quickFixOracle);`
	`136`	`+ this._onDidChangeFixes.fire(undefined);`
	`137`	`+ }`
`134`	`138`
`135`	`139`	`if (this._editor.getModel()`
`136`	`140`	`&& CodeActionProviderRegistry.has(this._editor.getModel())`
`137`	`141`	`&& !this._editor.getConfiguration().readOnly) {`
`138`	`142`
`139`	`143`	`this._quickFixOracle = new QuickFixOracle(this._editor, this._markerService, p => this._onDidChangeFixes.fire(p));`
`140`		`-`
`141`		`- } else {`
`142`		`- // signal unavailable`
`143`		`- this._onDidChangeFixes.fire(undefined);`
`144`	`144`	`}`
`145`	`145`	`}`
`146`	`146`