Improve isMarkdownString check

alexr00 · alexr00 · commit a9936ddd3512 · 2020-07-13T14:16:02.000+02:00
diff --git a/src/vs/workbench/api/common/extHostTypes.ts b/src/vs/workbench/api/common/extHostTypes.ts
@@ -1276,7 +1276,7 @@ export class MarkdownString {
 		if (thing instanceof MarkdownString) {
 			return true;
 		}
-		return (thing !== undefined) && thing.appendCodeblock && thing.appendMarkdown && thing.appendText && (thing.value !== undefined);
+		return thing && thing.appendCodeblock && thing.appendMarkdown && thing.appendText && (thing.value !== undefined);
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -1276,7 +1276,7 @@ export class MarkdownString {`
`1276`	`1276`	`if (thing instanceof MarkdownString) {`
`1277`	`1277`	`return true;`
`1278`	`1278`	`}`
`1279`		`- return (thing !== undefined) && thing.appendCodeblock && thing.appendMarkdown && thing.appendText && (thing.value !== undefined);`
	`1279`	`+ return thing && thing.appendCodeblock && thing.appendMarkdown && thing.appendText && (thing.value !== undefined);`
`1280`	`1280`	`}`
`1281`	`1281`	`}`
`1282`	`1282`