quick access - include history still when not searching

Benjamin Pasero · Benjamin Pasero · commit a8e13f1c8412 · 2020-03-18T10:52:46.000+01:00
diff --git a/src/vs/workbench/contrib/search/browser/anythingQuickAccess.ts b/src/vs/workbench/contrib/search/browser/anythingQuickAccess.ts
@@ -194,15 +194,16 @@ export class AnythingQuickAccessProvider extends PickerQuickAccessProvider<IAnyt
 	private readonly labelOnlyEditorHistoryPickAccessor = new QuickPickItemScorerAccessor({ skipDescription: true });
 
 	protected getEditorHistoryPicks(query: IPreparedQuery, range: IRange | undefined): Array<IAnythingQuickPickItem> {
-		if (!this.configuration.includeHistory) {
-			return []; // disabled
-		}
 
 		// Just return all history entries if not searching
 		if (!query.value) {
 			return this.historyService.getHistory().map(editor => this.createAnythingPick(editor, range));
 		}
 
+		if (!this.configuration.includeHistory) {
+			return []; // disabled when searching
+		}
+
 		// Only match on label of the editor unless the search includes path separators
 		const editorHistoryScorerAccessor = query.containsPathSeparator ? quickPickItemScorerAccessor : this.labelOnlyEditorHistoryPickAccessor;
 
