fixed scope

joaomoreno · joaomoreno · commit a8b09d47116d · 2019-10-25T15:14:59.000+02:00
diff --git a/extensions/git/package.json b/extensions/git/package.json
@@ -1252,7 +1252,8 @@
             "%config.countBadge.off%"
           ],
           "description": "%config.countBadge%",
-          "default": "all"
+          "default": "all",
+          "scope": "resource"
         },
         "git.checkoutType": {
           "type": "string",
@@ -1526,7 +1527,8 @@
             "%config.handleUntracked.hide%"
           ],
           "default": "withchanges",
-          "description": "%config.handleUntracked%"
+          "description": "%config.handleUntracked%",
+          "scope": "resource"
         }
       }
     },
diff --git a/extensions/git/src/commands.ts b/extensions/git/src/commands.ts
@@ -914,12 +914,8 @@ export class CommandCenter {
 			}
 		}
 
-		const handleUntracked =
-			workspace
-				.getConfiguration('git', Uri.file(repository.root))
-				.get<'withchanges' | 'separate' | 'hide'>('handleUntracked') ||
-			'withchanges';
-		let includeUntracked;
+		const handleUntracked = workspace.getConfiguration('git', Uri.file(repository.root)).get<'withchanges' | 'separate' | 'hide'>('handleUntracked');
+		let includeUntracked = false;
 		switch (handleUntracked) {
 			case 'withchanges':
 				includeUntracked = true;
diff --git a/extensions/git/src/repository.ts b/extensions/git/src/repository.ts
@@ -1447,6 +1447,7 @@ export class Repository implements Disposable {
 	private async updateModelState(): Promise<void> {
 		const { status, didHitLimit } = await this.repository.getStatus();
 		const config = workspace.getConfiguration('git');
+		const scopedConfig = workspace.getConfiguration('git', Uri.file(this.repository.root));
 		const shouldIgnore = config.get<boolean>('ignoreLimitWarning') === true;
 		const useIcons = !config.get<boolean>('decorations.enabled', true);
 		this.isRepositoryHuge = didHitLimit;
@@ -1507,9 +1508,7 @@ export class Repository implements Disposable {
 		this._submodules = submodules!;
 		this.rebaseCommit = rebaseCommit;
 
-		const handleUntracked =
-			config.get<'withchanges' | 'separate' | 'hide'>('handleUntracked') ||
-			'withchanges';
+		const handleUntracked = scopedConfig.get<'withchanges' | 'separate' | 'hide'>('handleUntracked');
 		const index: Resource[] = [];
 		const workingTree: Resource[] = [];
 		const merge: Resource[] = [];
@@ -1586,11 +1585,10 @@ export class Repository implements Disposable {
 	}
 
 	private setCountBadge(): void {
-		const config = workspace.getConfiguration('git');
-		const countBadge = config.get<string>('countBadge');
-		const handleUntracked =
-			config.get<'withchanges' | 'separate' | 'hide'>('handleUntracked') ||
-			'withchanges';
+		const config = workspace.getConfiguration('git', Uri.file(this.repository.root));
+		const countBadge = config.get<'all' | 'tracked' | 'off'>('countBadge');
+		const handleUntracked = config.get<'withchanges' | 'separate' | 'hide'>('handleUntracked');
+
 		let count =
 			this.mergeGroup.resourceStates.length +
 			this.indexGroup.resourceStates.length +

Original file line number	Diff line number	Diff line change
`@@ -914,12 +914,8 @@ export class CommandCenter {`
`914`	`914`	`}`
`915`	`915`	`}`
`916`	`916`
`917`		`- const handleUntracked =`
`918`		`- workspace`
`919`		`- .getConfiguration('git', Uri.file(repository.root))`
`920`		`- .get<'withchanges' \| 'separate' \| 'hide'>('handleUntracked') \|\|`
`921`		`- 'withchanges';`
`922`		`- let includeUntracked;`
	`917`	`+ const handleUntracked = workspace.getConfiguration('git', Uri.file(repository.root)).get<'withchanges' \| 'separate' \| 'hide'>('handleUntracked');`
	`918`	`+ let includeUntracked = false;`
`923`	`919`	`switch (handleUntracked) {`
`924`	`920`	`case 'withchanges':`
`925`	`921`	`includeUntracked = true;`