Do not install the watchdog if the extension host is debuggable (microsoft#26445)

alexdima · alexdima · commit a7fcaffcf4ee · 2017-08-14T14:27:20.000+02:00
diff --git a/src/vs/workbench/api/node/extHost.protocol.ts b/src/vs/workbench/api/node/extHost.protocol.ts
@@ -48,6 +48,7 @@ import { ITreeItem } from 'vs/workbench/parts/views/common/views';
 import { ThemeColor } from 'vs/platform/theme/common/themeService';
 
 export interface IEnvironment {
+	isExtensionDevelopmentDebug: boolean;
 	enableProposedApiForAll: boolean;
 	enableProposedApiFor: string | string[];
 	appSettingsHome: string;
diff --git a/src/vs/workbench/electron-browser/extensionHost.ts b/src/vs/workbench/electron-browser/extensionHost.ts
@@ -291,9 +291,10 @@ export class ExtensionHostProcessWorker {
 
 	private createExtHostInitData(): TPromise<IInitData> {
 		return TPromise.join<any>([this.telemetryService.getTelemetryInfo(), this.extensionService.getExtensions()]).then(([telemetryInfo, extensionDescriptions]) => {
-			return <IInitData>{
+			let r: IInitData = {
 				parentPid: process.pid,
 				environment: {
+					isExtensionDevelopmentDebug: this.isExtensionDevelopmentDebug,
 					appSettingsHome: this.environmentService.appSettingsHome,
 					disableExtensions: this.environmentService.disableExtensions,
 					userExtensionsHome: this.environmentService.extensionsPath,
@@ -308,6 +309,7 @@ export class ExtensionHostProcessWorker {
 				configuration: this.configurationService.getConfigurationData(),
 				telemetryInfo
 			};
+			return r;
 		});
 	}
 
diff --git a/src/vs/workbench/node/extensionHostMain.ts b/src/vs/workbench/node/extensionHostMain.ts
@@ -54,7 +54,9 @@ export class ExtensionHostMain {
 		errors.setUnexpectedErrorHandler(err => mainThreadErrors.onUnexpectedExtHostError(errors.transformErrorForSerialization(err)));
 
 		// Configure the watchdog to kill our process if the JS event loop is unresponsive for more than 10s
-		watchdog.start(10000);
+		if (!initData.environment.isExtensionDevelopmentDebug) {
+			watchdog.start(10000);
+		}
 	}
 
 	public start(): TPromise<void> {

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,9 @@ export class ExtensionHostMain {`
`54`	`54`	`errors.setUnexpectedErrorHandler(err => mainThreadErrors.onUnexpectedExtHostError(errors.transformErrorForSerialization(err)));`
`55`	`55`
`56`	`56`	`// Configure the watchdog to kill our process if the JS event loop is unresponsive for more than 10s`
`57`		`- watchdog.start(10000);`
	`57`	`+ if (!initData.environment.isExtensionDevelopmentDebug) {`
	`58`	`+ watchdog.start(10000);`
	`59`	`+ }`
`58`	`60`	`}`
`59`	`61`
`60`	`62`	`public start(): TPromise<void> {`