Skip to content

Commit a5afeca

Browse files
author
Benjamin Pasero
committed
"No Country for Old Electron"
1 parent 3d9d00f commit a5afeca

2 files changed

Lines changed: 10 additions & 10 deletions

File tree

‎src/vs/platform/windows/common/windows.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -103,9 +103,9 @@ export interface IWindowsService {
103103
pickFileAndOpen(options: INativeOpenDialogOptions): TPromise<void>;
104104
pickFolderAndOpen(options: INativeOpenDialogOptions): TPromise<void>;
105105
pickWorkspaceAndOpen(options: INativeOpenDialogOptions): TPromise<void>;
106-
showMessageBox(windowId: number, options: Electron.MessageBoxOptions): TPromise<IMessageBoxResult>;
107-
showSaveDialog(windowId: number, options: Electron.SaveDialogOptions): TPromise<string>;
108-
showOpenDialog(windowId: number, options: Electron.OpenDialogOptions): TPromise<string[]>;
106+
showMessageBox(windowId: number, options: MessageBoxOptions): TPromise<IMessageBoxResult>;
107+
showSaveDialog(windowId: number, options: SaveDialogOptions): TPromise<string>;
108+
showOpenDialog(windowId: number, options: OpenDialogOptions): TPromise<string[]>;
109109

110110
reloadWindow(windowId: number): TPromise<void>;
111111
openDevTools(windowId: number): TPromise<void>;

‎src/vs/platform/windows/common/windowsIpc.ts‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
import { TPromise } from 'vs/base/common/winjs.base';
99
import Event, { buffer } from 'vs/base/common/event';
1010
import { IChannel, eventToCall, eventFromCall } from 'vs/base/parts/ipc/common/ipc';
11-
import { IWindowsService, INativeOpenDialogOptions, IEnterWorkspaceResult, CrashReporterStartOptions, IMessageBoxResult } from 'vs/platform/windows/common/windows';
11+
import { IWindowsService, INativeOpenDialogOptions, IEnterWorkspaceResult, CrashReporterStartOptions, IMessageBoxResult, MessageBoxOptions, SaveDialogOptions, OpenDialogOptions } from 'vs/platform/windows/common/windows';
1212
import { IWorkspaceIdentifier, ISingleFolderWorkspaceIdentifier, IWorkspaceFolderCreationData } from 'vs/platform/workspaces/common/workspaces';
1313
import { IRecentlyOpened } from 'vs/platform/history/common/history';
1414
import { ICommandAction } from 'vs/platform/actions/common/actions';
@@ -22,9 +22,9 @@ export interface IWindowsChannel extends IChannel {
2222
call(command: 'pickFileAndOpen', arg: INativeOpenDialogOptions): TPromise<void>;
2323
call(command: 'pickFolderAndOpen', arg: INativeOpenDialogOptions): TPromise<void>;
2424
call(command: 'pickWorkspaceAndOpen', arg: INativeOpenDialogOptions): TPromise<void>;
25-
call(command: 'showMessageBox', arg: [number, Electron.MessageBoxOptions]): TPromise<IMessageBoxResult>;
26-
call(command: 'showSaveDialog', arg: [number, Electron.SaveDialogOptions]): TPromise<string>;
27-
call(command: 'showOpenDialog', arg: [number, Electron.OpenDialogOptions]): TPromise<string[]>;
25+
call(command: 'showMessageBox', arg: [number, MessageBoxOptions]): TPromise<IMessageBoxResult>;
26+
call(command: 'showSaveDialog', arg: [number, SaveDialogOptions]): TPromise<string>;
27+
call(command: 'showOpenDialog', arg: [number, OpenDialogOptions]): TPromise<string[]>;
2828
call(command: 'reloadWindow', arg: number): TPromise<void>;
2929
call(command: 'toggleDevTools', arg: number): TPromise<void>;
3030
call(command: 'closeWorkspace', arg: number): TPromise<void>;
@@ -178,15 +178,15 @@ export class WindowsChannelClient implements IWindowsService {
178178
return this.channel.call('pickWorkspaceAndOpen', options);
179179
}
180180

181-
showMessageBox(windowId: number, options: Electron.MessageBoxOptions): TPromise<IMessageBoxResult> {
181+
showMessageBox(windowId: number, options: MessageBoxOptions): TPromise<IMessageBoxResult> {
182182
return this.channel.call('showMessageBox', [windowId, options]);
183183
}
184184

185-
showSaveDialog(windowId: number, options: Electron.SaveDialogOptions): TPromise<string> {
185+
showSaveDialog(windowId: number, options: SaveDialogOptions): TPromise<string> {
186186
return this.channel.call('showSaveDialog', [windowId, options]);
187187
}
188188

189-
showOpenDialog(windowId: number, options: Electron.OpenDialogOptions): TPromise<string[]> {
189+
showOpenDialog(windowId: number, options: OpenDialogOptions): TPromise<string[]> {
190190
return this.channel.call('showOpenDialog', [windowId, options]);
191191
}
192192

0 commit comments

Comments
 (0)