Enabling the 'noUnusedLocals' compiler option for extensions

egamma · egamma · commit a54c44cb0d8b · 2017-11-08T10:23:49.000+01:00
diff --git a/extensions/css/client/tsconfig.json b/extensions/css/client/tsconfig.json
@@ -3,6 +3,7 @@
 		"target": "es5",
 		"module": "commonjs",
 		"outDir": "./out",
+		"noUnusedLocals": true,
 		"lib": [
 			"es5", "es2015.promise"
 		]
diff --git a/extensions/css/server/tsconfig.json b/extensions/css/server/tsconfig.json
@@ -3,6 +3,7 @@
 		"target": "es5",
 		"module": "commonjs",
 		"outDir": "./out",
+		"noUnusedLocals": true,
 		"lib": [
 			"es5"
 		]
diff --git a/extensions/extension-editing/src/extensionLinter.ts b/extensions/extension-editing/src/extensionLinter.ts
@@ -54,6 +54,7 @@ export class ExtensionLinter {
 	private timer: NodeJS.Timer;
 	private markdownIt: MarkdownItType.MarkdownIt;
 
+	// @ts-ignore unused property
 	constructor(private context: ExtensionContext) {
 		this.disposables.push(
 			workspace.onDidOpenTextDocument(document => this.queue(document)),
diff --git a/extensions/extension-editing/tsconfig.json b/extensions/extension-editing/tsconfig.json
@@ -5,6 +5,7 @@
 			"es2015"
 		],
 		"module": "commonjs",
+		"noUnusedLocals": true,
 		"outDir": "./out"
 	},
 	"include": [
diff --git a/extensions/html/client/tsconfig.json b/extensions/html/client/tsconfig.json
@@ -3,6 +3,7 @@
 		"target": "es5",
 		"module": "commonjs",
 		"outDir": "./out",
+		"noUnusedLocals": true,
 		"lib": [
 			"es5", "es2015.promise"
 		]
diff --git a/extensions/html/server/src/utils/edits.ts b/extensions/html/server/src/utils/edits.ts
@@ -15,6 +15,7 @@ export function applyEdits(document: TextDocument, edits: TextEdit[]): string {
 		}
 		return startDiff;
 	});
+	// @ts-ignore unused local
 	let lastOffset = text.length;
 	sortedEdits.forEach(e => {
 		let startOffset = document.offsetAt(e.range.start);
diff --git a/extensions/html/server/tsconfig.json b/extensions/html/server/tsconfig.json
@@ -3,6 +3,7 @@
 		"target": "es5",
 		"module": "commonjs",
 		"outDir": "./out",
+		"noUnusedLocals": true,
 		"lib": [
 			"es5", "es2015.promise"
 		]
diff --git a/extensions/json/client/src/jsonMain.ts b/extensions/json/client/src/jsonMain.ts
@@ -50,6 +50,7 @@ interface Settings {
 	};
 }
 
+// @ts-ignore unused type
 interface JSONSettings {
 	schemas: JSONSchemaSettings[];
 }
diff --git a/extensions/json/client/tsconfig.json b/extensions/json/client/tsconfig.json
@@ -3,6 +3,7 @@
 		"target": "es5",
 		"module": "commonjs",
 		"outDir": "./out",
+		"noUnusedLocals": true,
 		"lib": [
 			"es5", "es2015.promise"
 		]
diff --git a/extensions/json/server/tsconfig.json b/extensions/json/server/tsconfig.json
@@ -5,6 +5,7 @@
 		"sourceMap": true,
 		"sourceRoot": "../src",
 		"outDir": "./out",
+		"noUnusedLocals": true,
 		"lib": [
 			"es5", "es2015.promise"
 		]
diff --git a/extensions/vscode-api-tests/tsconfig.json b/extensions/vscode-api-tests/tsconfig.json
@@ -3,6 +3,7 @@
 		"module": "commonjs",
 		"target": "ES5",
 		"outDir": "out",
+		"noUnusedLocals": true,
 		"lib": [
 			"es2015"
 		],
diff --git a/extensions/vscode-colorize-tests/tsconfig.json b/extensions/vscode-colorize-tests/tsconfig.json
@@ -3,6 +3,7 @@
 		"module": "commonjs",
 		"target": "ES5",
 		"outDir": "out",
+		"noUnusedLocals": true,
 		"lib": [
 			"es2015"
 		],

Original file line number	Diff line number	Diff line change
`@@ -3,6 +3,7 @@`
`3`	`3`	`"target": "es5",`
`4`	`4`	`"module": "commonjs",`
`5`	`5`	`"outDir": "./out",`
	`6`	`+ "noUnusedLocals": true,`
`6`	`7`	`"lib": [`
`7`	`8`	`"es5", "es2015.promise"`
`8`	`9`	`]`
Original file line number	Diff line number	Diff line change
`@@ -15,6 +15,7 @@ export function applyEdits(document: TextDocument, edits: TextEdit[]): string {`
`15`	`15`	`}`
`16`	`16`	`return startDiff;`
`17`	`17`	`});`
	`18`	`+ // @ts-ignore unused local`
`18`	`19`	`let lastOffset = text.length;`
`19`	`20`	`sortedEdits.forEach(e => {`
`20`	`21`	`let startOffset = document.offsetAt(e.range.start);`
Original file line number	Diff line number	Diff line change
`@@ -50,6 +50,7 @@ interface Settings {`
`50`	`50`	`};`
`51`	`51`	`}`
`52`	`52`
	`53`	`+// @ts-ignore unused type`
`53`	`54`	`interface JSONSettings {`
`54`	`55`	`schemas: JSONSchemaSettings[];`
`55`	`56`	`}`
Original file line number	Diff line number	Diff line change
`@@ -5,6 +5,7 @@`
`5`	`5`	`"sourceMap": true,`
`6`	`6`	`"sourceRoot": "../src",`
`7`	`7`	`"outDir": "./out",`
	`8`	`+ "noUnusedLocals": true,`
`8`	`9`	`"lib": [`
`9`	`10`	`"es5", "es2015.promise"`
`10`	`11`	`]`