freeze FuzzyScore.Default, microsoft#74203

jrieken · jrieken · commit a330f0f57cb5 · 2019-05-23T17:35:20.000+02:00
diff --git a/src/vs/base/common/filters.ts b/src/vs/base/common/filters.ts
@@ -491,7 +491,7 @@ export namespace FuzzyScore {
 	/**
 	 * No matches and value `-100`
 	 */
-	export const Default: [-100, 0, 0] = [-100, 0, 0];
+	export const Default: [-100, 0, 0] = <[-100, 0, 0]>Object.freeze([-100, 0, 0]);
 
 	export function isDefault(score?: FuzzyScore): score is [-100, 0, 0] {
 		return !score || (score[0] === -100 && score[1] === 0 && score[2] === 0);
diff --git a/src/vs/editor/contrib/suggest/completionModel.ts b/src/vs/editor/contrib/suggest/completionModel.ts
@@ -222,7 +222,7 @@ export class CompletionModel {
 					} else {
 						// re-run the scorer on the label in the hope of a result BUT use the rank
 						// of the filterText-match
-						item.score = scoreFn(word, wordLow, wordPos, item.completion.label, item.labelLow, 0, false) || FuzzyScore.Default;
+						item.score = scoreFn(word, wordLow, wordPos, item.completion.label, item.labelLow, 0, false) || [-100, 0, 0];
 						item.score[0] = match[0]; // use score from filterText
 					}
 

Original file line number	Diff line number	Diff line change
`@@ -222,7 +222,7 @@ export class CompletionModel {`
`222`	`222`	`} else {`
`223`	`223`	`// re-run the scorer on the label in the hope of a result BUT use the rank`
`224`	`224`	`// of the filterText-match`
`225`		`- item.score = scoreFn(word, wordLow, wordPos, item.completion.label, item.labelLow, 0, false) \|\| FuzzyScore.Default;`
	`225`	`+ item.score = scoreFn(word, wordLow, wordPos, item.completion.label, item.labelLow, 0, false) \|\| [-100, 0, 0];`
`226`	`226`	`item.score[0] = match[0]; // use score from filterText`
`227`	`227`	`}`
`228`	`228`