editors - remove ugly cast

Benjamin Pasero · Benjamin Pasero · commit a30ddfa505d5 · 2020-02-21T11:29:35.000+01:00
diff --git a/src/vs/workbench/common/editor.ts b/src/vs/workbench/common/editor.ts
@@ -346,7 +346,7 @@ export interface IRevertOptions {
 }
 
 export interface IMoveResult {
-	editor: IEditorInput | IResourceEditor;
+	editor: EditorInput | IResourceEditor;
 	options?: IEditorOptions;
 }
 
diff --git a/src/vs/workbench/services/editor/browser/editorService.ts b/src/vs/workbench/services/editor/browser/editorService.ts
@@ -277,7 +277,7 @@ export class EditorService extends Disposable implements EditorServiceImpl {
 						replacement: {
 							...moveResult.editor,
 							options: {
-								...(moveResult.editor as IResourceEditor /* TS fail */).options,
+								...moveResult.editor.options,
 								...optionOverrides
 							}
 						}

Original file line number	Diff line number	Diff line change
`@@ -346,7 +346,7 @@ export interface IRevertOptions {`
`346`	`346`	`}`
`347`	`347`
`348`	`348`	`export interface IMoveResult {`
`349`		`- editor: IEditorInput \| IResourceEditor;`
	`349`	`+ editor: EditorInput \| IResourceEditor;`
`350`	`350`	`options?: IEditorOptions;`
`351`	`351`	`}`
`352`	`352`
Original file line number	Diff line number	Diff line change
`@@ -277,7 +277,7 @@ export class EditorService extends Disposable implements EditorServiceImpl {`
`277`	`277`	`replacement: {`
`278`	`278`	`...moveResult.editor,`
`279`	`279`	`options: {`
`280`		`- ...(moveResult.editor as IResourceEditor /* TS fail */).options,`
	`280`	`+ ...moveResult.editor.options,`
`281`	`281`	`...optionOverrides`
`282`	`282`	`}`
`283`	`283`	`}`