Don't try laying out disposed webview

mjbvz · mjbvz · commit a202ed92ed04 · 2019-05-28T10:17:19.000-07:00
Fixes microsoft#73733
diff --git a/src/vs/workbench/contrib/webview/electron-browser/webviewElement.ts b/src/vs/workbench/contrib/webview/electron-browser/webviewElement.ts
@@ -661,6 +661,9 @@ export class WebviewElement extends Disposable implements Webview {
 	}
 
 	public layout(): void {
+		if (!this._webview) {
+			return;
+		}
 		const contents = this._webview.getWebContents();
 		if (!contents || contents.isDestroyed()) {
 			return;

Original file line number	Diff line number	Diff line change
`@@ -661,6 +661,9 @@ export class WebviewElement extends Disposable implements Webview {`
`661`	`661`	`}`
`662`	`662`
`663`	`663`	`public layout(): void {`
	`664`	`+ if (!this._webview) {`
	`665`	`+ return;`
	`666`	`+ }`
`664`	`667`	`const contents = this._webview.getWebContents();`
`665`	`668`	`if (!contents \|\| contents.isDestroyed()) {`
`666`	`669`	`return;`