ext host - improve printing of circular objects

Benjamin Pasero · Benjamin Pasero · commit a057e3218bfd · 2018-08-14T16:31:21.000+02:00
diff --git a/src/bootstrap.js b/src/bootstrap.js
@@ -76,9 +76,9 @@ if (!!process.send && process.env.PIPE_LOGGING === 'true') {
 			res = JSON.stringify(argsArray, function (key, value) {
 
 				// Objects get special treatment to prevent circles
-				if (value && Object.prototype.toString.call(value) === '[object Object]') {
+				if (isObject(value) || Array.isArray(value)) {
 					if (seen.indexOf(value) !== -1) {
-						return Object.create(null); // prevent circular references!
+						return '[Circular]';
 					}
 
 					seen.push(value);
@@ -105,6 +105,14 @@ if (!!process.send && process.env.PIPE_LOGGING === 'true') {
 		}
 	}
 
+	function isObject(obj) {
+		return typeof obj === 'object'
+			&& obj !== null
+			&& !Array.isArray(obj)
+			&& !(obj instanceof RegExp)
+			&& !(obj instanceof Date);
+	}
+
 	// Pass console logging to the outside so that we have it in the main side if told so
 	if (process.env.VERBOSE_LOGGING === 'true') {
 		console.log = function () { safeSend({ type: '__$console', severity: 'log', arguments: safeToArray(arguments) }); };
