annotate todo

aeschli · aeschli · commit 9d045b323874 · 2020-04-21T12:03:48.000+02:00
diff --git a/src/vs/base/browser/ui/checkbox/checkbox.ts b/src/vs/base/browser/ui/checkbox/checkbox.ts
@@ -101,7 +101,7 @@ export class Checkbox extends Widget {
 		if (this._opts.icon) {
 			classes.push(this._opts.icon.classNames);
 		} else {
-			classes.push('codicon'); // todo: remove once codicon fully adopted
+			classes.push('codicon'); // todo@aeschli: remove once codicon fully adopted
 		}
 		if (this._opts.actionClassName) {
 			classes.push(this._opts.actionClassName);
diff --git a/src/vs/base/browser/ui/dropdown/dropdown.ts b/src/vs/base/browser/ui/dropdown/dropdown.ts
@@ -295,7 +295,7 @@ export class DropdownMenuActionViewItem extends BaseActionViewItem {
 
 	render(container: HTMLElement): void {
 		const labelRenderer: ILabelRenderer = (el: HTMLElement): IDisposable | null => {
-			this.element = append(el, $('a.action-label.codicon')); // TODO: remove codicon, should come through `this.clazz`
+			this.element = append(el, $('a.action-label.codicon')); // todo@aeschli: remove codicon, should come through `this.clazz`
 			if (this.clazz) {
 				addClasses(this.element, this.clazz);
 			}

Original file line number	Diff line number	Diff line change
`@@ -101,7 +101,7 @@ export class Checkbox extends Widget {`
`101`	`101`	`if (this._opts.icon) {`
`102`	`102`	`classes.push(this._opts.icon.classNames);`
`103`	`103`	`} else {`
`104`		`- classes.push('codicon'); // todo: remove once codicon fully adopted`
	`104`	`+ classes.push('codicon'); // todo@aeschli: remove once codicon fully adopted`
`105`	`105`	`}`
`106`	`106`	`if (this._opts.actionClassName) {`
`107`	`107`	`classes.push(this._opts.actionClassName);`
Original file line number	Diff line number	Diff line change
`@@ -295,7 +295,7 @@ export class DropdownMenuActionViewItem extends BaseActionViewItem {`
`295`	`295`
`296`	`296`	`render(container: HTMLElement): void {`
`297`	`297`	`const labelRenderer: ILabelRenderer = (el: HTMLElement): IDisposable \| null => {`
`298`		- this.element = append(el, $('a.action-label.codicon')); // TODO: remove codicon, should come through `this.clazz`
	`298`	+ this.element = append(el, $('a.action-label.codicon')); // todo@aeschli: remove codicon, should come through `this.clazz`
`299`	`299`	`if (this.clazz) {`
`300`	`300`	`addClasses(this.element, this.clazz);`
`301`	`301`	`}`