Skip to content

Commit 9ce155f

Browse files
author
Benjamin Pasero
committed
notifications - fix border shadow
1 parent 0614090 commit 9ce155f

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

src/vs/workbench/browser/parts/notifications/media/notificationsToasts.css

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@
2727

2828
.monaco-workbench > .notifications-toasts .notification-toast-container > .notification-toast {
2929
margin: 5px; /* enables separation and drop shadows around toasts */
30-
3130
transform: translateY(100%); /* move the notification 50px to the bottom (to prevent bleed through) */
3231
opacity: 0; /* fade the toast in */
3332
transition: transform 300ms ease-out, opacity 300ms ease-out;

src/vs/workbench/browser/parts/notifications/notificationsToasts.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ import { ILifecycleService, LifecyclePhase } from 'vs/platform/lifecycle/common/
2828
interface INotificationToast {
2929
list: NotificationsList;
3030
container: HTMLElement;
31+
toast: HTMLElement;
3132
disposeables: IDisposable[];
3233
}
3334

@@ -119,7 +120,7 @@ export class NotificationsToasts extends Themable {
119120
verticalScrollMode: ScrollbarVisibility.Hidden
120121
});
121122
itemDisposeables.push(notificationList);
122-
this.mapNotificationToToast.set(item, { list: notificationList, container: notificationToastContainer, disposeables: itemDisposeables });
123+
this.mapNotificationToToast.set(item, { list: notificationList, container: notificationToastContainer, toast: notificationToast, disposeables: itemDisposeables });
123124

124125
// Make visible
125126
notificationList.show();
@@ -312,9 +313,9 @@ export class NotificationsToasts extends Themable {
312313
}
313314

314315
protected updateStyles(): void {
315-
this.mapNotificationToToast.forEach(toast => {
316+
this.mapNotificationToToast.forEach(t => {
316317
const widgetShadowColor = this.getColor(widgetShadow);
317-
toast.container.style.boxShadow = widgetShadowColor ? `0 0px 8px ${widgetShadowColor}` : null;
318+
t.toast.style.boxShadow = widgetShadowColor ? `0 0px 8px ${widgetShadowColor}` : null;
318319
});
319320
}
320321

0 commit comments

Comments
 (0)