Fix microsoft#105895, duplicate auth providers in vscode.authentication.providers

Rachel Macfarlane · Rachel Macfarlane · commit 9cc09931cdc0 · 2020-09-02T13:55:43.000-07:00
diff --git a/src/vs/workbench/api/common/extHostAuthentication.ts b/src/vs/workbench/api/common/extHostAuthentication.ts
@@ -187,9 +187,9 @@ export class ExtHostAuthentication implements ExtHostAuthenticationShape {
 	}
 
 	$onDidChangeAuthenticationProviders(added: modes.AuthenticationProviderInformation[], removed: modes.AuthenticationProviderInformation[]) {
-		added.forEach(id => {
-			if (!this._providers.includes(id)) {
-				this._providers.push(id);
+		added.forEach(provider => {
+			if (!this._providers.some(p => p.id === provider.id)) {
+				this._providers.push(provider);
 			}
 		});
 

Original file line number	Diff line number	Diff line change
`@@ -187,9 +187,9 @@ export class ExtHostAuthentication implements ExtHostAuthenticationShape {`
`187`	`187`	`}`
`188`	`188`
`189`	`189`	`$onDidChangeAuthenticationProviders(added: modes.AuthenticationProviderInformation[], removed: modes.AuthenticationProviderInformation[]) {`
`190`		`- added.forEach(id => {`
`191`		`- if (!this._providers.includes(id)) {`
`192`		`- this._providers.push(id);`
	`190`	`+ added.forEach(provider => {`
	`191`	`+ if (!this._providers.some(p => p.id === provider.id)) {`
	`192`	`+ this._providers.push(provider);`
`193`	`193`	`}`
`194`	`194`	`});`
`195`	`195`