debug: allow thread name to get updated

isidorn · isidorn · commit 9cb6273ce836 · 2017-01-12T17:01:43.000+01:00
fixes microsoft#18244
diff --git a/src/vs/workbench/parts/debug/common/debugModel.ts b/src/vs/workbench/parts/debug/common/debugModel.ts
@@ -381,7 +381,7 @@ export class Thread implements debug.IThread {
 	}
 
 	public getId(): string {
-		return `thread:${this.process.getId()}:${this.name}:${this.threadId}`;
+		return `thread:${this.process.getId()}:${this.threadId}`;
 	}
 
 	public clearCallStack(): void {
@@ -506,6 +506,9 @@ export class Process implements debug.IProcess {
 		if (data.thread && !this.threads.has(data.threadId)) {
 			// A new thread came in, initialize it.
 			this.threads.set(data.threadId, new Thread(this, data.thread.name, data.thread.id));
+		} else if (data.thread && data.thread.name) {
+			// Just the thread name got updated #18244
+			this.threads.get(data.threadId).name = data.thread.name;
 		}
 
 		if (data.stoppedDetails) {

Original file line number	Diff line number	Diff line change
`@@ -381,7 +381,7 @@ export class Thread implements debug.IThread {`
`381`	`381`	`}`
`382`	`382`
`383`	`383`	`public getId(): string {`
`384`		- return `thread:${this.process.getId()}:${this.name}:${this.threadId}`;
	`384`	+ return `thread:${this.process.getId()}:${this.threadId}`;
`385`	`385`	`}`
`386`	`386`
`387`	`387`	`public clearCallStack(): void {`
`@@ -506,6 +506,9 @@ export class Process implements debug.IProcess {`
`506`	`506`	`if (data.thread && !this.threads.has(data.threadId)) {`
`507`	`507`	`// A new thread came in, initialize it.`
`508`	`508`	`this.threads.set(data.threadId, new Thread(this, data.thread.name, data.thread.id));`
	`509`	`+ } else if (data.thread && data.thread.name) {`
	`510`	`+ // Just the thread name got updated #18244`
	`511`	`+ this.threads.get(data.threadId).name = data.thread.name;`
`509`	`512`	`}`
`510`	`513`
`511`	`514`	`if (data.stoppedDetails) {`