Skip to content

Commit 9bfcfac

Browse files
author
annkamsk
committed
Replace innerHTML with innerText when assigning non-html string
1 parent 59ef2e3 commit 9bfcfac

7 files changed

Lines changed: 17 additions & 17 deletions

File tree

‎src/vs/code/electron-sandbox/issue/issueReporterMain.ts‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -713,7 +713,7 @@ export class IssueReporter extends Disposable {
713713
}
714714
}
715715

716-
sourceSelect.innerHTML = '';
716+
sourceSelect.innerText = '';
717717
if (issueType === IssueType.FeatureRequest) {
718718
sourceSelect.append(...[
719719
this.makeOption('', localize('selectSource', "Select source"), true),
@@ -1079,7 +1079,7 @@ export class IssueReporter extends Disposable {
10791079
}
10801080

10811081
private updateExtensionTable(extensions: IssueReporterExtensionData[], numThemeExtensions: number): void {
1082-
const target = document.querySelector('.block-extensions .block-info');
1082+
const target = document.querySelector<HTMLElement>('.block-extensions .block-info');
10831083
if (target) {
10841084
if (this.configuration.disableExtensions) {
10851085
target.innerHTML = localize('disabledExtensions', "Extensions are disabled");
@@ -1090,7 +1090,7 @@ export class IssueReporter extends Disposable {
10901090
extensions = extensions || [];
10911091

10921092
if (!extensions.length) {
1093-
target.innerHTML = 'Extensions: none' + themeExclusionStr;
1093+
target.innerText = 'Extensions: none' + themeExclusionStr;
10941094
return;
10951095
}
10961096

@@ -1100,10 +1100,10 @@ export class IssueReporter extends Disposable {
11001100
}
11011101

11021102
private updateSearchedExtensionTable(extensions: IssueReporterExtensionData[]): void {
1103-
const target = document.querySelector('.block-searchedExtensions .block-info');
1103+
const target = document.querySelector<HTMLElement>('.block-searchedExtensions .block-info');
11041104
if (target) {
11051105
if (!extensions.length) {
1106-
target.innerHTML = 'Extensions: none';
1106+
target.innerText = 'Extensions: none';
11071107
return;
11081108
}
11091109

‎src/vs/editor/browser/config/charWidthReader.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -124,12 +124,12 @@ class DomCharWidthReader {
124124

125125
private static _render(testElement: HTMLElement, request: CharWidthRequest): void {
126126
if (request.chr === ' ') {
127-
let htmlString = '&#160;';
127+
let htmlString = '\u00a0';
128128
// Repeat character 256 (2^8) times
129129
for (let i = 0; i < 8; i++) {
130130
htmlString += htmlString;
131131
}
132-
testElement.innerHTML = htmlString;
132+
testElement.innerText = htmlString;
133133
} else {
134134
let testString = request.chr;
135135
// Repeat character 256 (2^8) times

‎src/vs/editor/browser/widget/diffReview.ts‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -702,7 +702,7 @@ export class DiffReview extends Disposable {
702702
if (originalLine !== 0) {
703703
originalLineNumber.appendChild(document.createTextNode(String(originalLine)));
704704
} else {
705-
originalLineNumber.innerHTML = '&#160;';
705+
originalLineNumber.innerText = '\u00a0';
706706
}
707707
cell.appendChild(originalLineNumber);
708708

@@ -714,7 +714,7 @@ export class DiffReview extends Disposable {
714714
if (modifiedLine !== 0) {
715715
modifiedLineNumber.appendChild(document.createTextNode(String(modifiedLine)));
716716
} else {
717-
modifiedLineNumber.innerHTML = '&#160;';
717+
modifiedLineNumber.innerText = '\u00a0';
718718
}
719719
cell.appendChild(modifiedLineNumber);
720720

@@ -724,10 +724,10 @@ export class DiffReview extends Disposable {
724724
if (spacerIcon) {
725725
const spacerCodicon = document.createElement('span');
726726
spacerCodicon.className = spacerIcon.classNames;
727-
spacerCodicon.innerHTML = '&#160;&#160;';
727+
spacerCodicon.innerText = '\u00a0\u00a0';
728728
spacer.appendChild(spacerCodicon);
729729
} else {
730-
spacer.innerHTML = '&#160;&#160;';
730+
spacer.innerText = '\u00a0\u00a0';
731731
}
732732
cell.appendChild(spacer);
733733

‎src/vs/editor/contrib/codelens/codelensWidget.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ class CodeLensContentWidget implements IContentWidget {
108108
} else {
109109
// symbols and commands
110110
if (!innerHtml) {
111-
innerHtml = '&#160;';
111+
innerHtml = '\u00a0';
112112
}
113113
this._domNode.innerHTML = innerHtml;
114114
if (this._isEmpty && animate) {

‎src/vs/editor/test/browser/controller/imeTester.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ function doCreateTest(description: string, inputStr: string, expectedStr: string
7474
container.appendChild(title);
7575

7676
let startBtn = document.createElement('button');
77-
startBtn.innerHTML = 'Start';
77+
startBtn.innerText = 'Start';
7878
container.appendChild(startBtn);
7979

8080

@@ -141,10 +141,10 @@ function doCreateTest(description: string, inputStr: string, expectedStr: string
141141

142142
let expected = 'some ' + expectedStr + ' text';
143143
if (text === expected) {
144-
check.innerHTML = '[GOOD]';
144+
check.innerText = '[GOOD]';
145145
check.className = 'check good';
146146
} else {
147-
check.innerHTML = '[BAD]';
147+
check.innerText = '[BAD]';
148148
check.className = 'check bad';
149149
}
150150
check.innerHTML += expected;

‎src/vs/workbench/browser/parts/editor/breadcrumbsControl.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ class Item extends BreadcrumbsItem {
9898
} else if (this.element instanceof OutlineModel) {
9999
// has outline element but not in one
100100
let label = document.createElement('div');
101-
label.innerHTML = '&hellip;';
101+
label.innerText = '\u2026';
102102
label.className = 'hint-more';
103103
container.appendChild(label);
104104

‎src/vs/workbench/contrib/welcome/walkThrough/browser/walkThroughPart.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -268,7 +268,7 @@ export class WalkThroughPart extends BaseEditor {
268268
}
269269

270270
this.contentDisposables = dispose(this.contentDisposables);
271-
this.content.innerHTML = '';
271+
this.content.innerText = '';
272272

273273
return super.setInput(input, options, token)
274274
.then(() => {

0 commit comments

Comments
 (0)