main - stackTraceLimit = 100

Benjamin Pasero · Benjamin Pasero · commit 9b6c69c8c865 · 2018-03-13T07:40:00.000+01:00
diff --git a/src/main.js b/src/main.js
@@ -10,6 +10,8 @@ perf.mark('main:started');
 // Perf measurements
 global.perfStartTime = Date.now();
 
+Error.stackTraceLimit = 100; // increase number of stack frames (from 10, https://github.com/v8/v8/wiki/Stack-Trace-API)
+
 //#region Add support for using node_modules.asar
 (function () {
 	const path = require('path');
@@ -366,7 +368,7 @@ function getNLSConfiguration(locale) {
 								}
 								target[module] = targetStrings;
 							}
-							writes.push(writeFile(path.join(coreLocation, bundle.replace(/\//g,'!') + '.nls.json'), JSON.stringify(target)));
+							writes.push(writeFile(path.join(coreLocation, bundle.replace(/\//g, '!') + '.nls.json'), JSON.stringify(target)));
 						}
 						writes.push(writeFile(translationsConfigFile, JSON.stringify(packConfig.translations)));
 						return Promise.all(writes);
diff --git a/src/vs/code/electron-main/window.ts b/src/vs/code/electron-main/window.ts
@@ -878,7 +878,9 @@ export class CodeWindow implements ICodeWindow {
 	}
 
 	public send(channel: string, ...args: any[]): void {
-		this._win.webContents.send(channel, ...args);
+		if (this._win) {
+			this._win.webContents.send(channel, ...args);
+		}
 	}
 
 	public updateTouchBar(groups: ICommandAction[][]): void {

Original file line number	Diff line number	Diff line change
`@@ -10,6 +10,8 @@ perf.mark('main:started');`
`10`	`10`	`// Perf measurements`
`11`	`11`	`global.perfStartTime = Date.now();`
`12`	`12`
	`13`	`+Error.stackTraceLimit = 100; // increase number of stack frames (from 10, https://github.com/v8/v8/wiki/Stack-Trace-API)`
	`14`	`+`
`13`	`15`	`//#region Add support for using node_modules.asar`
`14`	`16`	`(function () {`
`15`	`17`	`const path = require('path');`
`@@ -366,7 +368,7 @@ function getNLSConfiguration(locale) {`
`366`	`368`	`}`
`367`	`369`	`target[module] = targetStrings;`
`368`	`370`	`}`
`369`		`- writes.push(writeFile(path.join(coreLocation, bundle.replace(/\//g,'!') + '.nls.json'), JSON.stringify(target)));`
	`371`	`+ writes.push(writeFile(path.join(coreLocation, bundle.replace(/\//g, '!') + '.nls.json'), JSON.stringify(target)));`
`370`	`372`	`}`
`371`	`373`	`writes.push(writeFile(translationsConfigFile, JSON.stringify(packConfig.translations)));`
`372`	`374`	`return Promise.all(writes);`
Original file line number	Diff line number	Diff line change
`@@ -878,7 +878,9 @@ export class CodeWindow implements ICodeWindow {`
`878`	`878`	`}`
`879`	`879`
`880`	`880`	`public send(channel: string, ...args: any[]): void {`
`881`		`- this._win.webContents.send(channel, ...args);`
	`881`	`+ if (this._win) {`
	`882`	`+ this._win.webContents.send(channel, ...args);`
	`883`	`+ }`
`882`	`884`	`}`
`883`	`885`
`884`	`886`	`public updateTouchBar(groups: ICommandAction[][]): void {`