Move state check ahead to ensure stale docs are not made visible microsoft#29468

ramya-rao-a · ramya-rao-a · commit 99ffa6afcf86 · 2017-06-26T10:14:35.000-07:00
diff --git a/src/vs/editor/contrib/suggest/browser/suggestWidget.ts b/src/vs/editor/contrib/suggest/browser/suggestWidget.ts
@@ -850,6 +850,10 @@ export class SuggestWidget implements IContentWidget, IDelegate<ICompletionItem>
 			this.editor.layoutContentWidget(this);
 			this.telemetryService.publicLog('suggestWidget:collapseDetails', this.editor.getTelemetryData());
 		} else {
+			if (this.state !== State.Open && this.state !== State.Details) {
+				return;
+			}
+
 			this.updateExpandDocsSetting(true);
 			this.showDetails();
 			this.telemetryService.publicLog('suggestWidget:expandDetails', this.editor.getTelemetryData());
@@ -858,13 +862,10 @@ export class SuggestWidget implements IContentWidget, IDelegate<ICompletionItem>
 	}
 
 	showDetails(): void {
-		if (this.state !== State.Open && this.state !== State.Details) {
-			return;
-		}
 		this.expandSideOrBelow();
 
 		show(this.details.element);
-		this.renderDetails();
+		this.details.render(this.list.getFocusedElements()[0]);
 		this.details.element.style.maxHeight = this.maxWidgetHeight + 'px';
 
 		// Reset margin-top that was set as Fix for #26416
@@ -980,14 +981,6 @@ export class SuggestWidget implements IContentWidget, IDelegate<ICompletionItem>
 		}
 	}
 
-	private renderDetails(): void {
-		if (this.state === State.Details || this.state === State.Open) {
-			this.details.render(this.list.getFocusedElements()[0]);
-		} else {
-			this.details.render(null);
-		}
-	}
-
 	// Heights
 
 	private get maxWidgetHeight(): number {
