Let read-only editors show problems (fixes microsoft#89057)

Benjamin Pasero · Benjamin Pasero · commit 982a71938c38 · 2020-01-24T08:37:35.000+01:00
diff --git a/src/vs/workbench/browser/parts/editor/textEditor.ts b/src/vs/workbench/browser/parts/editor/textEditor.ts
@@ -109,7 +109,10 @@ export abstract class BaseTextEditor extends BaseEditor implements ITextEditor {
 			overviewRulerLanes: 3,
 			lineNumbersMinChars: 3,
 			fixedOverflowWidgets: true,
-			readOnly: this.input?.isReadonly()
+			readOnly: this.input?.isReadonly(),
+			// render problems even in readonly editors
+			// https://github.com/microsoft/vscode/issues/89057
+			renderValidationDecorations: 'on'
 		};
 	}
 
diff --git a/src/vs/workbench/contrib/output/browser/logViewer.ts b/src/vs/workbench/contrib/output/browser/logViewer.ts
@@ -63,6 +63,7 @@ export class LogViewer extends AbstractTextResourceEditor {
 		options.wordWrap = 'off'; // all log viewers do not wrap
 		options.folding = false;
 		options.scrollBeyondLastLine = false;
+		options.renderValidationDecorations = 'editable';
 		return options;
 	}
 }
diff --git a/src/vs/workbench/contrib/output/browser/outputPanel.ts b/src/vs/workbench/contrib/output/browser/outputPanel.ts
@@ -95,6 +95,7 @@ export class OutputPanel extends AbstractTextResourceEditor {
 		options.scrollBeyondLastLine = false;
 		options.renderLineHighlight = 'none';
 		options.minimap = { enabled: false };
+		options.renderValidationDecorations = 'editable';
 
 		const outputConfig = this.configurationService.getValue<any>('[Log]');
 		if (outputConfig) {
diff --git a/src/vs/workbench/contrib/preferences/browser/preferencesEditor.ts b/src/vs/workbench/contrib/preferences/browser/preferencesEditor.ts
@@ -1021,6 +1021,7 @@ export class DefaultPreferencesEditor extends BaseTextEditor {
 			options.minimap = {
 				enabled: false
 			};
+			options.renderValidationDecorations = 'editable';
 		}
 		return options;
 	}

Original file line number	Diff line number	Diff line change
`@@ -63,6 +63,7 @@ export class LogViewer extends AbstractTextResourceEditor {`
`63`	`63`	`options.wordWrap = 'off'; // all log viewers do not wrap`
`64`	`64`	`options.folding = false;`
`65`	`65`	`options.scrollBeyondLastLine = false;`
	`66`	`+ options.renderValidationDecorations = 'editable';`
`66`	`67`	`return options;`
`67`	`68`	`}`
`68`	`69`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1021,6 +1021,7 @@ export class DefaultPreferencesEditor extends BaseTextEditor {`
`1021`	`1021`	`options.minimap = {`
`1022`	`1022`	`enabled: false`
`1023`	`1023`	`};`
	`1024`	`+ options.renderValidationDecorations = 'editable';`
`1024`	`1025`	`}`
`1025`	`1026`	`return options;`
`1026`	`1027`	`}`