re microsoft#103454. notebook/comments/find remove toggle.

rebornix · rebornix · commit 97af4fb370ae · 2020-09-24T15:00:18.000-07:00
diff --git a/src/vs/workbench/contrib/codeEditor/browser/find/simpleFindReplaceWidget.ts b/src/vs/workbench/contrib/codeEditor/browser/find/simpleFindReplaceWidget.ts
@@ -314,7 +314,7 @@ export abstract class SimpleFindReplaceWidget extends Widget {
 		this._replaceBtn.setEnabled(this._isVisible && this._isReplaceVisible && findInputIsNonEmpty);
 		this._replaceAllBtn.setEnabled(this._isVisible && this._isReplaceVisible && findInputIsNonEmpty);
 
-		dom.toggleClass(this._domNode, 'replaceToggled', this._isReplaceVisible);
+		this._domNode.classList.toggle('replaceToggled', this._isReplaceVisible);
 		this._toggleReplaceBtn.setExpanded(this._isReplaceVisible);
 	}
 
diff --git a/src/vs/workbench/contrib/comments/browser/commentsView.ts b/src/vs/workbench/contrib/comments/browser/commentsView.ts
@@ -113,7 +113,7 @@ export class CommentsPanel extends ViewPane {
 	}
 
 	private async renderComments(): Promise<void> {
-		dom.toggleClass(this.treeContainer, 'hidden', !this.commentsModel.hasCommentThreads());
+		this.treeContainer.classList.toggle('hidden', !this.commentsModel.hasCommentThreads());
 		await this.tree.setInput(this.commentsModel);
 		this.renderMessage();
 	}
@@ -144,7 +144,7 @@ export class CommentsPanel extends ViewPane {
 
 	private renderMessage(): void {
 		this.messageBox.textContent = this.commentsModel.getMessage();
-		dom.toggleClass(this.messageBoxContainer, 'hidden', this.commentsModel.hasCommentThreads());
+		this.messageBoxContainer.classList.toggle('hidden', this.commentsModel.hasCommentThreads());
 	}
 
 	private createTree(): void {
@@ -237,7 +237,7 @@ export class CommentsPanel extends ViewPane {
 				this.collapseAllAction.enabled = this.commentsModel.hasCommentThreads();
 			}
 
-			dom.toggleClass(this.treeContainer, 'hidden', !this.commentsModel.hasCommentThreads());
+			this.treeContainer.classList.toggle('hidden', !this.commentsModel.hasCommentThreads());
 			this.tree.updateChildren().then(() => {
 				this.renderMessage();
 			}, (e) => {
diff --git a/src/vs/workbench/contrib/notebook/browser/notebookEditorWidget.ts b/src/vs/workbench/contrib/notebook/browser/notebookEditorWidget.ts
@@ -861,8 +861,8 @@ export class NotebookEditorWidget extends Disposable implements INotebookEditor
 		const notebookMetadata = this.viewModel!.metadata;
 		this._editorEditable?.set(!!notebookMetadata?.editable);
 		this._editorRunnable?.set(!!notebookMetadata?.runnable);
-		DOM.toggleClass(this._overlayContainer, 'notebook-editor-editable', !!notebookMetadata?.editable);
-		DOM.toggleClass(this.getDomNode(), 'notebook-editor-editable', !!notebookMetadata?.editable);
+		this._overflowContainer.classList.toggle('notebook-editor-editable', !!notebookMetadata?.editable);
+		this.getDomNode().classList.toggle('notebook-editor-editable', !!notebookMetadata?.editable);
 
 		this._notebookExecuting?.set(notebookMetadata.runState === NotebookRunState.Running);
 	}
diff --git a/src/vs/workbench/contrib/notebook/browser/view/output/transforms/richTransform.ts b/src/vs/workbench/contrib/notebook/browser/view/output/transforms/richTransform.ts
@@ -186,7 +186,7 @@ class RichRenderer implements IOutputTransformContribution {
 		const image = document.createElement('img');
 		image.src = `data:image/png;base64,${output.data['image/png']}`;
 		const display = document.createElement('div');
-		DOM.addClasses(display, 'display');
+		display.classList.add('display');
 		display.appendChild(image);
 		container.appendChild(display);
 		return { type: RenderOutputType.None, hasDynamicHeight: true };
@@ -196,7 +196,7 @@ class RichRenderer implements IOutputTransformContribution {
 		const image = document.createElement('img');
 		image.src = `data:image/jpeg;base64,${output.data['image/jpeg']}`;
 		const display = document.createElement('div');
-		DOM.addClasses(display, 'display');
+		display.classList.add('display');
 		display.appendChild(image);
 		container.appendChild(display);
 		return { type: RenderOutputType.None, hasDynamicHeight: true };
diff --git a/src/vs/workbench/contrib/notebook/browser/view/renderers/cellRenderer.ts b/src/vs/workbench/contrib/notebook/browser/view/renderers/cellRenderer.ts
@@ -785,7 +785,7 @@ export class CodeCellRenderer extends AbstractCellRenderer implements IListRende
 
 	private updateForMetadata(element: CodeCellViewModel, templateData: CodeCellRenderTemplate): void {
 		const metadata = element.getEvaluatedMetadata(this.notebookEditor.viewModel!.notebookDocument.metadata);
-		DOM.toggleClass(templateData.container, 'runnable', !!metadata.runnable);
+		templateData.container.classList.toggle('runnable', !!metadata.runnable);
 		this.updateExecutionOrder(metadata, templateData);
 		templateData.statusBar.cellStatusMessageContainer.textContent = metadata?.statusMessage || '';
 
@@ -826,7 +826,7 @@ export class CodeCellRenderer extends AbstractCellRenderer implements IListRende
 	}
 
 	private updateForHover(element: CodeCellViewModel, templateData: CodeCellRenderTemplate): void {
-		DOM.toggleClass(templateData.container, 'cell-output-hover', element.outputIsHovered);
+		templateData.container.classList.toggle('cell-output-hover', element.outputIsHovered);
 	}
 
 	private updateForLayout(element: CodeCellViewModel, templateData: CodeCellRenderTemplate): void {
diff --git a/src/vs/workbench/contrib/notebook/browser/view/renderers/codeCell.ts b/src/vs/workbench/contrib/notebook/browser/view/renderers/codeCell.ts
@@ -84,7 +84,7 @@ export class CodeCell extends Disposable {
 				templateData.editor?.focus();
 			}
 
-			DOM.toggleClass(templateData.container, 'cell-editor-focus', viewCell.focusMode === CellFocusMode.Editor);
+			templateData.container.classList.toggle('cell-editor-focus', viewCell.focusMode === CellFocusMode.Editor);
 		};
 		const updateForCollapseState = () => {
 			this.viewUpdate();

Original file line number	Diff line number	Diff line change
`@@ -314,7 +314,7 @@ export abstract class SimpleFindReplaceWidget extends Widget {`
`314`	`314`	`this._replaceBtn.setEnabled(this._isVisible && this._isReplaceVisible && findInputIsNonEmpty);`
`315`	`315`	`this._replaceAllBtn.setEnabled(this._isVisible && this._isReplaceVisible && findInputIsNonEmpty);`
`316`	`316`
`317`		`- dom.toggleClass(this._domNode, 'replaceToggled', this._isReplaceVisible);`
	`317`	`+ this._domNode.classList.toggle('replaceToggled', this._isReplaceVisible);`
`318`	`318`	`this._toggleReplaceBtn.setExpanded(this._isReplaceVisible);`
`319`	`319`	`}`
`320`	`320`
Original file line number	Diff line number	Diff line change
`@@ -113,7 +113,7 @@ export class CommentsPanel extends ViewPane {`
`113`	`113`	`}`
`114`	`114`
`115`	`115`	`private async renderComments(): Promise<void> {`
`116`		`- dom.toggleClass(this.treeContainer, 'hidden', !this.commentsModel.hasCommentThreads());`
	`116`	`+ this.treeContainer.classList.toggle('hidden', !this.commentsModel.hasCommentThreads());`
`117`	`117`	`await this.tree.setInput(this.commentsModel);`
`118`	`118`	`this.renderMessage();`
`119`	`119`	`}`
`@@ -144,7 +144,7 @@ export class CommentsPanel extends ViewPane {`
`144`	`144`
`145`	`145`	`private renderMessage(): void {`
`146`	`146`	`this.messageBox.textContent = this.commentsModel.getMessage();`
`147`		`- dom.toggleClass(this.messageBoxContainer, 'hidden', this.commentsModel.hasCommentThreads());`
	`147`	`+ this.messageBoxContainer.classList.toggle('hidden', this.commentsModel.hasCommentThreads());`
`148`	`148`	`}`
`149`	`149`
`150`	`150`	`private createTree(): void {`
`@@ -237,7 +237,7 @@ export class CommentsPanel extends ViewPane {`
`237`	`237`	`this.collapseAllAction.enabled = this.commentsModel.hasCommentThreads();`
`238`	`238`	`}`
`239`	`239`
`240`		`- dom.toggleClass(this.treeContainer, 'hidden', !this.commentsModel.hasCommentThreads());`
	`240`	`+ this.treeContainer.classList.toggle('hidden', !this.commentsModel.hasCommentThreads());`
`241`	`241`	`this.tree.updateChildren().then(() => {`
`242`	`242`	`this.renderMessage();`
`243`	`243`	`}, (e) => {`
Original file line number	Diff line number	Diff line change
`@@ -785,7 +785,7 @@ export class CodeCellRenderer extends AbstractCellRenderer implements IListRende`
`785`	`785`
`786`	`786`	`private updateForMetadata(element: CodeCellViewModel, templateData: CodeCellRenderTemplate): void {`
`787`	`787`	`const metadata = element.getEvaluatedMetadata(this.notebookEditor.viewModel!.notebookDocument.metadata);`
`788`		`- DOM.toggleClass(templateData.container, 'runnable', !!metadata.runnable);`
	`788`	`+ templateData.container.classList.toggle('runnable', !!metadata.runnable);`
`789`	`789`	`this.updateExecutionOrder(metadata, templateData);`
`790`	`790`	`templateData.statusBar.cellStatusMessageContainer.textContent = metadata?.statusMessage \|\| '';`
`791`	`791`
`@@ -826,7 +826,7 @@ export class CodeCellRenderer extends AbstractCellRenderer implements IListRende`
`826`	`826`	`}`
`827`	`827`
`828`	`828`	`private updateForHover(element: CodeCellViewModel, templateData: CodeCellRenderTemplate): void {`
`829`		`- DOM.toggleClass(templateData.container, 'cell-output-hover', element.outputIsHovered);`
	`829`	`+ templateData.container.classList.toggle('cell-output-hover', element.outputIsHovered);`
`830`	`830`	`}`
`831`	`831`
`832`	`832`	`private updateForLayout(element: CodeCellViewModel, templateData: CodeCellRenderTemplate): void {`
Original file line number	Diff line number	Diff line change
`@@ -84,7 +84,7 @@ export class CodeCell extends Disposable {`
`84`	`84`	`templateData.editor?.focus();`
`85`	`85`	`}`
`86`	`86`
`87`		`- DOM.toggleClass(templateData.container, 'cell-editor-focus', viewCell.focusMode === CellFocusMode.Editor);`
	`87`	`+ templateData.container.classList.toggle('cell-editor-focus', viewCell.focusMode === CellFocusMode.Editor);`
`88`	`88`	`};`
`89`	`89`	`const updateForCollapseState = () => {`
`90`	`90`	`this.viewUpdate();`