ignore showPreview option when needsConfirmation is set, microsoft#77728

jrieken · jrieken · commit 973dab0eada1 · 2020-01-20T12:32:40.000+01:00
diff --git a/src/vs/workbench/services/bulkEdit/browser/bulkEditService.ts b/src/vs/workbench/services/bulkEdit/browser/bulkEditService.ts
@@ -398,7 +398,7 @@ export class BulkEditService implements IBulkEditService {
 			return { ariaSummary: localize('nothing', "Made no edits") };
 		}
 
-		if (this._previewHandler && options?.showPreview) {
+		if (this._previewHandler && (options?.showPreview || edit.edits.some(value => value.metadata?.needsConfirmation))) {
 			edit = await this._previewHandler(edit, options);
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -398,7 +398,7 @@ export class BulkEditService implements IBulkEditService {`
`398`	`398`	`return { ariaSummary: localize('nothing', "Made no edits") };`
`399`	`399`	`}`
`400`	`400`
`401`		`- if (this._previewHandler && options?.showPreview) {`
	`401`	`+ if (this._previewHandler && (options?.showPreview \|\| edit.edits.some(value => value.metadata?.needsConfirmation))) {`
`402`	`402`	`edit = await this._previewHandler(edit, options);`
`403`	`403`	`}`
`404`	`404`