Use more explicit variable name

mjbvz · mjbvz · commit 96fb1b87ea14 · 2019-08-21T18:15:27.000-07:00
diff --git a/src/vs/editor/contrib/parameterHints/parameterHintsModel.ts b/src/vs/editor/contrib/parameterHints/parameterHintsModel.ts
@@ -52,7 +52,7 @@ export class ParameterHintsModel extends Disposable {
 	public readonly onChangedHints = this._onChangedHints.event;
 
 	private readonly editor: ICodeEditor;
-	private enabled: boolean;
+	private triggerOnType = false;
 	private _state: ParameterHintState.State = ParameterHintState.Default;
 	private readonly _lastSignatureHelpResult = this._register(new MutableDisposable<modes.SignatureHelpResult>());
 	private triggerChars = new CharacterSet();
@@ -68,7 +68,6 @@ export class ParameterHintsModel extends Disposable {
 		super();
 
 		this.editor = editor;
-		this.enabled = false;
 
 		this.throttledDelayer = new Delayer(delay);
 
@@ -242,7 +241,7 @@ export class ParameterHintsModel extends Disposable {
 	}
 
 	private onDidType(text: string) {
-		if (!this.enabled) {
+		if (!this.triggerOnType) {
 			return;
 		}
 
@@ -272,9 +271,9 @@ export class ParameterHintsModel extends Disposable {
 	}
 
 	private onEditorConfigurationChange(): void {
-		this.enabled = this.editor.getConfiguration().contribInfo.parameterHints.enabled;
+		this.triggerOnType = this.editor.getConfiguration().contribInfo.parameterHints.enabled;
 
-		if (!this.enabled) {
+		if (!this.triggerOnType) {
 			this.cancel();
 		}
 	}
@@ -283,4 +282,4 @@ export class ParameterHintsModel extends Disposable {
 		this.cancel(true);
 		super.dispose();
 	}
-}
+}

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ export class ParameterHintsModel extends Disposable {`
`52`	`52`	`public readonly onChangedHints = this._onChangedHints.event;`
`53`	`53`
`54`	`54`	`private readonly editor: ICodeEditor;`
`55`		`- private enabled: boolean;`
	`55`	`+ private triggerOnType = false;`
`56`	`56`	`private _state: ParameterHintState.State = ParameterHintState.Default;`
`57`	`57`	`private readonly _lastSignatureHelpResult = this._register(new MutableDisposable<modes.SignatureHelpResult>());`
`58`	`58`	`private triggerChars = new CharacterSet();`
`@@ -68,7 +68,6 @@ export class ParameterHintsModel extends Disposable {`
`68`	`68`	`super();`
`69`	`69`
`70`	`70`	`this.editor = editor;`
`71`		`- this.enabled = false;`
`72`	`71`
`73`	`72`	`this.throttledDelayer = new Delayer(delay);`
`74`	`73`
`@@ -242,7 +241,7 @@ export class ParameterHintsModel extends Disposable {`
`242`	`241`	`}`
`243`	`242`
`244`	`243`	`private onDidType(text: string) {`
`245`		`- if (!this.enabled) {`
	`244`	`+ if (!this.triggerOnType) {`
`246`	`245`	`return;`
`247`	`246`	`}`
`248`	`247`
`@@ -272,9 +271,9 @@ export class ParameterHintsModel extends Disposable {`
`272`	`271`	`}`
`273`	`272`
`274`	`273`	`private onEditorConfigurationChange(): void {`
`275`		`- this.enabled = this.editor.getConfiguration().contribInfo.parameterHints.enabled;`
	`274`	`+ this.triggerOnType = this.editor.getConfiguration().contribInfo.parameterHints.enabled;`
`276`	`275`
`277`		`- if (!this.enabled) {`
	`276`	`+ if (!this.triggerOnType) {`
`278`	`277`	`this.cancel();`
`279`	`278`	`}`
`280`	`279`	`}`
`@@ -283,4 +282,4 @@ export class ParameterHintsModel extends Disposable {`
`283`	`282`	`this.cancel(true);`
`284`	`283`	`super.dispose();`
`285`	`284`	`}`
`286`		`-}`
	`285`	`+}`