Add hasModel guard before using model

mjbvz · mjbvz · commit 9598b8d09192 · 2019-03-11T16:20:06.000-07:00
diff --git a/src/vs/workbench/browser/parts/editor/editorStatus.ts b/src/vs/workbench/browser/parts/editor/editorStatus.ts
@@ -1128,7 +1128,7 @@ export class ChangeEOLAction extends Action {
 		return this.quickInputService.pick(EOLOptions, { placeHolder: nls.localize('pickEndOfLine', "Select End of Line Sequence"), activeItem: EOLOptions[selectedIndex] }).then(eol => {
 			if (eol) {
 				const activeCodeEditor = getCodeEditor(this.editorService.activeTextEditorWidget);
-				if (activeCodeEditor && isWritableCodeEditor(activeCodeEditor)) {
+				if (activeCodeEditor && activeCodeEditor.hasModel() && isWritableCodeEditor(activeCodeEditor)) {
 					const textModel = activeCodeEditor.getModel();
 					textModel.pushEOL(eol.eol);
 				}

Original file line number	Diff line number	Diff line change
`@@ -1128,7 +1128,7 @@ export class ChangeEOLAction extends Action {`
`1128`	`1128`	`return this.quickInputService.pick(EOLOptions, { placeHolder: nls.localize('pickEndOfLine', "Select End of Line Sequence"), activeItem: EOLOptions[selectedIndex] }).then(eol => {`
`1129`	`1129`	`if (eol) {`
`1130`	`1130`	`const activeCodeEditor = getCodeEditor(this.editorService.activeTextEditorWidget);`
`1131`		`- if (activeCodeEditor && isWritableCodeEditor(activeCodeEditor)) {`
	`1131`	`+ if (activeCodeEditor && activeCodeEditor.hasModel() && isWritableCodeEditor(activeCodeEditor)) {`
`1132`	`1132`	`const textModel = activeCodeEditor.getModel();`
`1133`	`1133`	`textModel.pushEOL(eol.eol);`
`1134`	`1134`	`}`