grid - fix to set height: 100% on editor container

Benjamin Pasero · Benjamin Pasero · commit 94094e2a6d20 · 2018-05-18T13:11:45.000+02:00
diff --git a/src/vs/workbench/browser/parts/editor2/media/nextEditorGroupView.css b/src/vs/workbench/browser/parts/editor2/media/nextEditorGroupView.css
@@ -38,12 +38,7 @@
 	overflow: hidden;
 }
 
-.monaco-workbench > .part.editor > .content .editor-group-container > .editor-container {
-	height: calc(100% - 35px); /* below title control */
-}
-
-.monaco-workbench > .part.editor > .content .editor-group-container.empty > .title,
-.monaco-workbench > .part.editor > .content .editor-group-container.empty > .editor-container  {
+.monaco-workbench > .part.editor > .content .editor-group-container.empty > .title {
 	display: none;
 }
 
@@ -79,4 +74,18 @@
 .vs-dark .monaco-workbench > .part.editor > .content .editor-group-container > .editor-group-container-toolbar .close-editor-group,
 .hc-black .monaco-workbench > .part.editor > .content .editor-group-container > .editor-group-container-toolbar .close-editor-group {
 	background-image: url('close-inverse.svg');
+}
+
+/* Editor */
+
+.monaco-workbench > .part.editor > .content .editor-group-container > .editor-container {
+	height: calc(100% - 35px); /* below title control */
+}
+
+.monaco-workbench > .part.editor > .content .editor-group-container.empty > .editor-container  {
+	display: none;
+}
+
+.monaco-workbench > .part.editor > .content .editor-group-container > .editor-container > .editor-instance {
+	height: 100%;
 }
diff --git a/src/vs/workbench/browser/parts/editor2/nextEditorControl.ts b/src/vs/workbench/browser/parts/editor2/nextEditorControl.ts
@@ -7,7 +7,7 @@
 
 import { Disposable } from 'vs/base/common/lifecycle';
 import { EditorInput, EditorOptions } from 'vs/workbench/common/editor';
-import { Dimension, show, hide } from 'vs/base/browser/dom';
+import { Dimension, show, hide, addClass } from 'vs/base/browser/dom';
 import { Registry } from 'vs/platform/registry/common/platform';
 import { IEditorRegistry, Extensions as EditorExtensions, IEditorDescriptor } from 'vs/workbench/browser/editor';
 import { TPromise } from 'vs/base/common/winjs.base';
@@ -95,6 +95,7 @@ export class NextEditorControl extends Disposable {
 		// Create editor container as needed
 		if (!control.getContainer()) {
 			const controlInstanceContainer = document.createElement('div');
+			addClass(controlInstanceContainer, 'editor-instance');
 			controlInstanceContainer.id = descriptor.getId();
 
 			control.create(controlInstanceContainer);
diff --git a/test/smoke/src/application.ts b/test/smoke/src/application.ts
@@ -63,7 +63,7 @@ export class Application {
 	async start(): Promise<any> {
 		await this._start();
 		await this.code.waitForElement('.explorer-folders-view');
-		await this.code.waitForActiveElement(`.editor-container[id="workbench.editor.walkThroughPart"] > div > div[tabIndex="0"]`);
+		await this.code.waitForActiveElement(`.editor-instance[id="workbench.editor.walkThroughPart"] > div > div[tabIndex="0"]`);
 	}
 
 	async restart(options: { workspaceOrFolder?: string, extraArgs?: string[] }): Promise<any> {
diff --git a/test/smoke/src/areas/editor/editors.ts b/test/smoke/src/areas/editor/editors.ts
@@ -23,7 +23,7 @@ export class Editors {
 	}
 
 	async waitForActiveEditor(filename: string): Promise<any> {
-		const selector = `.editor-container .monaco-editor[data-uri$="${filename}"] textarea`;
+		const selector = `.editor-instance .monaco-editor[data-uri$="${filename}"] textarea`;
 		return this.code.waitForActiveElement(selector);
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,7 @@ export class Application {`
`63`	`63`	`async start(): Promise<any> {`
`64`	`64`	`await this._start();`
`65`	`65`	`await this.code.waitForElement('.explorer-folders-view');`
`66`		- await this.code.waitForActiveElement(`.editor-container[id="workbench.editor.walkThroughPart"] > div > div[tabIndex="0"]`);
	`66`	+ await this.code.waitForActiveElement(`.editor-instance[id="workbench.editor.walkThroughPart"] > div > div[tabIndex="0"]`);
`67`	`67`	`}`
`68`	`68`
`69`	`69`	`async restart(options: { workspaceOrFolder?: string, extraArgs?: string[] }): Promise<any> {`
Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@ export class Editors {`
`23`	`23`	`}`
`24`	`24`
`25`	`25`	`async waitForActiveEditor(filename: string): Promise<any> {`
`26`		- const selector = `.editor-container .monaco-editor[data-uri$="${filename}"] textarea`;
	`26`	+ const selector = `.editor-instance .monaco-editor[data-uri$="${filename}"] textarea`;
`27`	`27`	`return this.code.waitForActiveElement(selector);`
`28`	`28`	`}`
`29`	`29`