Handle relative paths (microsoft#58694)

chrmarti · chrmarti · commit 92cc41ebd061 · 2018-09-26T15:19:36.000+02:00
diff --git a/extensions/extension-editing/src/extensionLinter.ts b/extensions/extension-editing/src/extensionLinter.ts
@@ -291,23 +291,24 @@ export class ExtensionLinter {
 	}
 
 	private addDiagnostics(diagnostics: Diagnostic[], document: TextDocument, begin: number, end: number, src: string, context: Context, info: PackageJsonInfo) {
+		const hasScheme = /^\w[\w\d+.-]*:/.test(src);
 		const uri = parseUri(src, info.repository ? info.repository.toString() : document.uri.toString());
 		if (!uri) {
 			return;
 		}
 		const scheme = uri.scheme.toLowerCase();
 
-		if (scheme !== 'https' && scheme !== 'data') {
+		if (hasScheme && scheme !== 'https' && scheme !== 'data') {
 			const range = new Range(document.positionAt(begin), document.positionAt(end));
 			diagnostics.push(new Diagnostic(range, httpsRequired, DiagnosticSeverity.Warning));
 		}
 
-		if (scheme === 'data') {
+		if (hasScheme && scheme === 'data') {
 			const range = new Range(document.positionAt(begin), document.positionAt(end));
 			diagnostics.push(new Diagnostic(range, dataUrlsNotValid, DiagnosticSeverity.Warning));
 		}
 
-		if (!info.hasHttpsRepository) {
+		if (!hasScheme && !info.hasHttpsRepository) {
 			const range = new Range(document.positionAt(begin), document.positionAt(end));
 			let message = (() => {
 				switch (context) {

Original file line number	Diff line number	Diff line change
`@@ -291,23 +291,24 @@ export class ExtensionLinter {`
`291`	`291`	`}`
`292`	`292`
`293`	`293`	`private addDiagnostics(diagnostics: Diagnostic[], document: TextDocument, begin: number, end: number, src: string, context: Context, info: PackageJsonInfo) {`
	`294`	`+ const hasScheme = /^\w[\w\d+.-]*:/.test(src);`
`294`	`295`	`const uri = parseUri(src, info.repository ? info.repository.toString() : document.uri.toString());`
`295`	`296`	`if (!uri) {`
`296`	`297`	`return;`
`297`	`298`	`}`
`298`	`299`	`const scheme = uri.scheme.toLowerCase();`
`299`	`300`
`300`		`- if (scheme !== 'https' && scheme !== 'data') {`
	`301`	`+ if (hasScheme && scheme !== 'https' && scheme !== 'data') {`
`301`	`302`	`const range = new Range(document.positionAt(begin), document.positionAt(end));`
`302`	`303`	`diagnostics.push(new Diagnostic(range, httpsRequired, DiagnosticSeverity.Warning));`
`303`	`304`	`}`
`304`	`305`
`305`		`- if (scheme === 'data') {`
	`306`	`+ if (hasScheme && scheme === 'data') {`
`306`	`307`	`const range = new Range(document.positionAt(begin), document.positionAt(end));`
`307`	`308`	`diagnostics.push(new Diagnostic(range, dataUrlsNotValid, DiagnosticSeverity.Warning));`
`308`	`309`	`}`
`309`	`310`
`310`		`- if (!info.hasHttpsRepository) {`
	`311`	`+ if (!hasScheme && !info.hasHttpsRepository) {`
`311`	`312`	`const range = new Range(document.positionAt(begin), document.positionAt(end));`
`312`	`313`	`let message = (() => {`
`313`	`314`	`switch (context) {`