workspaces - do not leave stale untitled workspaces around

Benjamin Pasero · Benjamin Pasero · commit 90a0ecc49e60 · 2020-06-26T10:47:35.000+02:00
diff --git a/src/vs/workbench/services/workspaces/browser/abstractWorkspaceEditingService.ts b/src/vs/workbench/services/workspaces/browser/abstractWorkspaceEditingService.ts
@@ -200,8 +200,11 @@ export abstract class AbstractWorkspaceEditingService implements IWorkspaceEditi
 		const remoteAuthority = this.environmentService.configuration.remoteAuthority;
 		const untitledWorkspace = await this.workspacesService.createUntitledWorkspace(folders, remoteAuthority);
 		if (path) {
-			await this.saveWorkspaceAs(untitledWorkspace, path);
-			await this.workspacesService.deleteUntitledWorkspace(untitledWorkspace); // https://github.com/microsoft/vscode/issues/100276
+			try {
+				await this.saveWorkspaceAs(untitledWorkspace, path);
+			} finally {
+				await this.workspacesService.deleteUntitledWorkspace(untitledWorkspace); // https://github.com/microsoft/vscode/issues/100276
+			}
 		} else {
 			path = untitledWorkspace.configPath;
 		}
