fix CancelablePromise.finally

joaomoreno · joaomoreno · commit 8f8e1fb2664c · 2019-01-24T09:16:14.000+01:00
related to microsoft#67027
diff --git a/src/vs/base/common/async.ts b/src/vs/base/common/async.ts
@@ -45,7 +45,7 @@ export function createCancelablePromise<T>(callback: (token: CancellationToken)
 			return this.then(undefined, reject);
 		}
 		finally(onfinally?: (() => void) | undefined | null): Promise<T> {
-			return this.finally(onfinally);
+			return promise.finally(onfinally);
 		}
 	};
 }

Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@ export function createCancelablePromise<T>(callback: (token: CancellationToken)`
`45`	`45`	`return this.then(undefined, reject);`
`46`	`46`	`}`
`47`	`47`	`finally(onfinally?: (() => void) \| undefined \| null): Promise<T> {`
`48`		`- return this.finally(onfinally);`
	`48`	`+ return promise.finally(onfinally);`
`49`	`49`	`}`
`50`	`50`	`};`
`51`	`51`	`}`