Skip to content

Commit 8d44139

Browse files
author
Miguel Solorio
committed
Adopt codicons in comment reactions widget
1 parent ec2ed03 commit 8d44139

10 files changed

Lines changed: 2 additions & 64 deletions

File tree

‎src/vs/workbench/contrib/comments/browser/commentNode.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ export class CommentNode extends Disposable {
158158
},
159159
this.actionRunner!,
160160
undefined,
161-
'toolbar-toggle-pickReactions',
161+
'toolbar-toggle-pickReactions codicon codicon-reactions',
162162
() => { return AnchorAlignment.RIGHT; }
163163
);
164164
}

‎src/vs/workbench/contrib/comments/browser/commentThreadWidget.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ import { KeyCode } from 'vs/base/common/keyCodes';
5050
import { StandardKeyboardEvent } from 'vs/base/browser/keyboardEvent';
5151

5252
export const COMMENTEDITOR_DECORATION_KEY = 'commenteditordecoration';
53-
const COLLAPSE_ACTION_CLASS = 'expand-review-action';
53+
const COLLAPSE_ACTION_CLASS = 'expand-review-action codicon-chevron-up';
5454
const COMMENT_SCHEME = 'comment';
5555

5656

‎src/vs/workbench/contrib/comments/browser/media/close-dark.svg‎

Lines changed: 0 additions & 3 deletions
This file was deleted.

‎src/vs/workbench/contrib/comments/browser/media/close-hc.svg‎

Lines changed: 0 additions & 3 deletions
This file was deleted.

‎src/vs/workbench/contrib/comments/browser/media/close-light.svg‎

Lines changed: 0 additions & 3 deletions
This file was deleted.

‎src/vs/workbench/contrib/comments/browser/media/close.svg‎

Lines changed: 0 additions & 1 deletion
This file was deleted.

‎src/vs/workbench/contrib/comments/browser/media/reaction-dark.svg‎

Lines changed: 0 additions & 3 deletions
This file was deleted.

‎src/vs/workbench/contrib/comments/browser/media/reaction-hc.svg‎

Lines changed: 0 additions & 3 deletions
This file was deleted.

‎src/vs/workbench/contrib/comments/browser/media/reaction-light.svg‎

Lines changed: 0 additions & 3 deletions
This file was deleted.

‎src/vs/workbench/contrib/comments/browser/media/review.css‎

Lines changed: 0 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -146,22 +146,8 @@
146146
margin-right: 4px;
147147
}
148148

149-
.monaco-editor .review-widget .head .review-actions > .monaco-action-bar .codicon.expand-review-action {
150-
background-image: url("./close-light.svg");
151-
background-size: 16px;
152-
}
153-
154-
.monaco-editor.vs-dark .review-widget .head .review-actions > .monaco-action-bar .codicon.expand-review-action {
155-
background-image: url("./close-dark.svg");
156-
}
157-
158-
.monaco-editor.hc-black .review-widget .head .review-actions > .monaco-action-bar .codicon.expand-review-action {
159-
background-image: url("./close-hc.svg");
160-
}
161-
162149
.monaco-editor .review-widget .body .review-comment .review-comment-contents .comment-reactions .action-item a.action-label.toolbar-toggle-pickReactions {
163150
display: none;
164-
background-image: url("./reaction-light.svg");
165151
background-size: 16px;
166152
width: 26px;
167153
height: 16px;
@@ -176,14 +162,6 @@
176162
background-size: 16px;
177163
}
178164

179-
.monaco-editor.vs-dark .review-widget .body .review-comment .review-comment-contents .comment-reactions .action-item a.action-label.toolbar-toggle-pickReactions {
180-
background-image: url("./reaction-dark.svg");
181-
}
182-
183-
.monaco-editor.hc-black .review-widget .body .review-comment .review-comment-contents .comment-reactions .action-item a.action-label.toolbar-toggle-pickReactions {
184-
background-image: url("./reaction-hc.svg");
185-
}
186-
187165
.monaco-editor .review-widget .body .review-comment .comment-title .action-label {
188166
display: block;
189167
height: 16px;
@@ -193,23 +171,6 @@
193171
background-repeat: no-repeat;
194172
}
195173

196-
.monaco-editor .review-widget .body .review-comment .comment-title .action-label.toolbar-toggle-pickReactions {
197-
background-image: url("./reaction-light.svg");
198-
width: 16px;
199-
height: 16px;
200-
background-size: 16px;
201-
background-position: center;
202-
background-repeat: no-repeat;
203-
}
204-
205-
.monaco-editor.vs-dark .review-widget .body .review-comment .comment-title .action-label.toolbar-toggle-pickReactions {
206-
background-image: url("./reaction-dark.svg");
207-
}
208-
209-
.monaco-editor.hc-black .review-widget .body .review-comment .comment-title .action-label.toolbar-toggle-pickReactions {
210-
background-image: url("./reaction-hc.svg");
211-
}
212-
213174
.monaco-editor .review-widget .body .review-comment .review-comment-contents .comment-reactions .action-item a.action-label {
214175
border: 1px solid transparent;
215176
}
@@ -412,10 +373,6 @@
412373
margin: 0;
413374
}
414375

415-
.monaco-editor .review-widget .head .review-actions .action-label.codicon.close-review-action {
416-
background: url("./close.svg") center center no-repeat;
417-
}
418-
419376
.monaco-editor .review-widget > .body {
420377
border-top: 1px solid;
421378
position: relative;

0 commit comments

Comments
 (0)