remove MainThreadWebviews hack

jrieken · jrieken · commit 8d35ebb7d8e1 · 2019-02-13T12:47:46.000+01:00
diff --git a/src/vs/workbench/api/electron-browser/mainThreadWebview.ts b/src/vs/workbench/api/electron-browser/mainThreadWebview.ts
@@ -22,8 +22,6 @@ import { ITelemetryService } from 'vs/platform/telemetry/common/telemetry';
 import { onUnexpectedError } from 'vs/base/common/errors';
 import { ExtensionIdentifier } from 'vs/platform/extensions/common/extensions';
 
-// todo@joh not nice!
-export let mainThreadWebviews: MainThreadWebviews;
 
 @extHostNamedCustomer(MainContext.MainThreadWebviews)
 export class MainThreadWebviews implements MainThreadWebviewsShape, WebviewReviver {
@@ -54,7 +52,6 @@ export class MainThreadWebviews implements MainThreadWebviewsShape, WebviewReviv
 		@IExtensionService private readonly _extensionService: IExtensionService,
 		@ITelemetryService private readonly _telemetryService: ITelemetryService
 	) {
-		mainThreadWebviews = this;
 		this._proxy = context.getProxy(ExtHostContext.ExtHostWebviews);
 		_editorService.onDidActiveEditorChange(this.onActiveEditorChanged, this, this._toDispose);
 		_editorService.onDidVisibleEditorsChange(this.onVisibleEditorsChanged, this, this._toDispose);
diff --git a/src/vs/workbench/parts/codeinset/codeInsetWidget.ts b/src/vs/workbench/parts/codeinset/codeInsetWidget.ts
@@ -12,7 +12,7 @@ import { ModelDecorationOptions } from 'vs/editor/common/model/textModel';
 import { IModelDeltaDecoration, IModelDecorationsChangeAccessor, ITextModel } from 'vs/editor/common/model';
 import { INotificationService } from 'vs/platform/notification/common/notification';
 import { WebviewEditorInput } from 'vs/workbench/contrib/webview/electron-browser/webviewEditorInput';
-import { mainThreadWebviews, MainThreadWebviews } from 'vs/workbench/api/electron-browser/mainThreadWebview';
+import { MainThreadWebviews } from 'vs/workbench/api/electron-browser/mainThreadWebview';
 import { UriComponents } from 'vs/base/common/uri';
 
 
@@ -144,7 +144,7 @@ export class CodeInsetWidget {
 
 	static webviewPool = 1;
 
-	public createWebview(mainThreadWebview: MainThreadWebviews, extensionLocation: UriComponents) {
+	public createWebview(mainThreadWebviews: MainThreadWebviews, extensionLocation: UriComponents) {
 		if (this._webviewHandle) { return this._webviewHandle; }
 
 		const lineNumber = this._range.endLineNumber;
