Simplify IExtensionService.onDidRegisterExtensions

alexdima · alexdima · commit 8ce17addb232 · 2018-02-23T17:38:22.000+01:00
diff --git a/src/vs/platform/actions/test/common/menuService.test.ts b/src/vs/platform/actions/test/common/menuService.test.ts
@@ -21,8 +21,8 @@ class MockExtensionService implements IExtensionService {
 
 	public _serviceBrand: any;
 
-	private _onDidRegisterExtensions = new Emitter<IExtensionDescription[]>();
-	public get onDidRegisterExtensions(): Event<IExtensionDescription[]> {
+	private _onDidRegisterExtensions = new Emitter<void>();
+	public get onDidRegisterExtensions(): Event<void> {
 		return this._onDidRegisterExtensions.event;
 	}
 
diff --git a/src/vs/platform/commands/test/commandService.test.ts b/src/vs/platform/commands/test/commandService.test.ts
@@ -17,8 +17,8 @@ import { NullLogService } from 'vs/platform/log/common/log';
 
 class SimpleExtensionService implements IExtensionService {
 	_serviceBrand: any;
-	private _onDidRegisterExtensions = new Emitter<IExtensionDescription[]>();
-	get onDidRegisterExtensions(): Event<IExtensionDescription[]> {
+	private _onDidRegisterExtensions = new Emitter<void>();
+	get onDidRegisterExtensions(): Event<void> {
 		return this._onDidRegisterExtensions.event;
 	}
 	onDidChangeExtensionsStatus = null;
diff --git a/src/vs/platform/extensions/common/extensions.ts b/src/vs/platform/extensions/common/extensions.ts
@@ -129,7 +129,7 @@ export interface IExtensionService {
 	 *
 	 * @returns the extensions that got registered
 	 */
-	onDidRegisterExtensions: Event<IExtensionDescription[]>;
+	onDidRegisterExtensions: Event<void>;
 
 	/**
 	 * @event
diff --git a/src/vs/workbench/services/extensions/electron-browser/extensionService.ts b/src/vs/workbench/services/extensions/electron-browser/extensionService.ts
@@ -113,7 +113,7 @@ const NO_OP_VOID_PROMISE = TPromise.wrap<void>(void 0);
 export class ExtensionService extends Disposable implements IExtensionService {
 	public _serviceBrand: any;
 
-	private _onDidRegisterExtensions: Emitter<IExtensionDescription[]>;
+	private _onDidRegisterExtensions: Emitter<void>;
 
 	private _registry: ExtensionDescriptionRegistry;
 	private readonly _installedExtensionsReady: Barrier;
@@ -158,7 +158,7 @@ export class ExtensionService extends Disposable implements IExtensionService {
 		this._extensionsMessages = {};
 		this._allRequestedActivateEvents = Object.create(null);
 
-		this._onDidRegisterExtensions = new Emitter<IExtensionDescription[]>();
+		this._onDidRegisterExtensions = new Emitter<void>();
 
 		this._extensionHostProcessFinishedActivateEvents = Object.create(null);
 		this._extensionHostProcessActivationTimes = Object.create(null);
@@ -204,7 +204,7 @@ export class ExtensionService extends Disposable implements IExtensionService {
 		super.dispose();
 	}
 
-	public get onDidRegisterExtensions(): Event<IExtensionDescription[]> {
+	public get onDidRegisterExtensions(): Event<void> {
 		return this._onDidRegisterExtensions.event;
 	}
 
@@ -443,7 +443,7 @@ export class ExtensionService extends Disposable implements IExtensionService {
 
 				mark('extensionHostReady');
 				this._installedExtensionsReady.open();
-				this._onDidRegisterExtensions.fire(availableExtensions);
+				this._onDidRegisterExtensions.fire(void 0);
 				this._onDidChangeExtensionsStatus.fire(availableExtensions.map(e => e.id));
 			});
 	}

Original file line number	Diff line number	Diff line change
`@@ -21,8 +21,8 @@ class MockExtensionService implements IExtensionService {`
`21`	`21`
`22`	`22`	`public _serviceBrand: any;`
`23`	`23`
`24`		`- private _onDidRegisterExtensions = new Emitter<IExtensionDescription[]>();`
`25`		`- public get onDidRegisterExtensions(): Event<IExtensionDescription[]> {`
	`24`	`+ private _onDidRegisterExtensions = new Emitter<void>();`
	`25`	`+ public get onDidRegisterExtensions(): Event<void> {`
`26`	`26`	`return this._onDidRegisterExtensions.event;`
`27`	`27`	`}`
`28`	`28`
Original file line number	Diff line number	Diff line change
`@@ -129,7 +129,7 @@ export interface IExtensionService {`
`129`	`129`	`*`
`130`	`130`	`* @returns the extensions that got registered`
`131`	`131`	`*/`
`132`		`- onDidRegisterExtensions: Event<IExtensionDescription[]>;`
	`132`	`+ onDidRegisterExtensions: Event<void>;`
`133`	`133`
`134`	`134`	`/**`
`135`	`135`	`* @event`