Fixes microsoft#6281: Do not truncate line number, column in position

alexdima · alexdima · commit 8cd47bb55ef1 · 2016-05-13T15:09:57.000+02:00
diff --git a/extensions/vscode-api-tests/src/editor.test.ts b/extensions/vscode-api-tests/src/editor.test.ts
@@ -8,7 +8,7 @@
 import * as assert from 'assert';
 import * as fs from 'fs';
 import * as os from 'os';
-import {workspace, window, Position} from 'vscode';
+import {workspace, window, Position, Range} from 'vscode';
 import {createRandomFile, deleteFile, cleanUp} from './utils';
 import {join} from 'path';
 
@@ -38,4 +38,27 @@ suite("editor tests", () => {
 			});
 		});
 	});
+
+	test('issue #6281: Edits fail to validate ranges correctly before applying', () => {
+		return createRandomFile('Hello world!').then(file => {
+			return workspace.openTextDocument(file).then(doc => {
+				return window.showTextDocument(doc).then((editor) => {
+					return editor.edit((builder) => {
+						builder.replace(new Range(0, 0, Number.MAX_VALUE, Number.MAX_VALUE), 'new');
+					}).then(applied => {
+						assert.ok(applied);
+						assert.equal(doc.getText(), 'new');
+						assert.ok(doc.isDirty);
+
+						return doc.save().then(saved => {
+							assert.ok(saved);
+							assert.ok(!doc.isDirty);
+
+							return deleteFile(file);
+						});
+					});
+				});
+			});
+		});
+	});
 });
diff --git a/src/vs/editor/common/core/position.ts b/src/vs/editor/common/core/position.ts
@@ -12,8 +12,8 @@ export class Position implements IEditorPosition {
 	public column: number;
 
 	constructor(lineNumber: number, column: number) {
-		this.lineNumber = lineNumber|0;
-		this.column = column|0;
+		this.lineNumber = lineNumber;
+		this.column = column;
 	}
 
 	public equals(other:IPosition): boolean {

Original file line number	Diff line number	Diff line change
`@@ -12,8 +12,8 @@ export class Position implements IEditorPosition {`
`12`	`12`	`public column: number;`
`13`	`13`
`14`	`14`	`constructor(lineNumber: number, column: number) {`
`15`		`- this.lineNumber = lineNumber\|0;`
`16`		`- this.column = column\|0;`
	`15`	`+ this.lineNumber = lineNumber;`
	`16`	`+ this.column = column;`
`17`	`17`	`}`
`18`	`18`
`19`	`19`	`public equals(other:IPosition): boolean {`