Skip to content

Commit 8c5452b

Browse files
kieferrmkieferrm
committed
applying new GDPR classification guidelines
1 parent 7ef742f commit 8c5452b

9 files changed

Lines changed: 18 additions & 18 deletions

File tree

‎src/vs/code/electron-browser/issue/issueReporterMain.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -519,7 +519,7 @@ export class IssueReporter extends Disposable {
519519
this.logService.warn('issueReporter#search ', error.message);
520520
/* __GDPR__
521521
"issueReporterSearchError" : {
522-
"message" : { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth" }
522+
"message" : { "classification": "CallstackOrException", "purpose": "PerformanceAndHealth" }
523523
}
524524
*/
525525
this.telemetryService.publicLog('issueReporterSearchError', { message: error.message });

‎src/vs/platform/extensionManagement/node/extensionGalleryService.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -635,7 +635,7 @@ export class ExtensionGalleryService implements IExtensionGalleryService {
635635
"galleryService:requestError" : {
636636
"url" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
637637
"cdn": { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
638-
"message": { "classification": "SystemMetaData", "purpose": "FeatureInsight" }
638+
"message": { "classification": "CallstackOrException", "purpose": "FeatureInsight" }
639639
}
640640
*/
641641
this.telemetryService.publicLog('galleryService:requestError', { url, cdn: true, message });
@@ -658,7 +658,7 @@ export class ExtensionGalleryService implements IExtensionGalleryService {
658658
"galleryService:requestError" : {
659659
"url" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
660660
"cdn": { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
661-
"message": { "classification": "SystemMetaData", "purpose": "FeatureInsight" }
661+
"message": { "classification": "CallstackOrException", "purpose": "FeatureInsight" }
662662
}
663663
*/
664664
this.telemetryService.publicLog('galleryService:requestError', { url: fallbackUrl, cdn: false, message });

‎src/vs/platform/telemetry/browser/errorTelemetry.ts‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -145,12 +145,12 @@ export default class ErrorTelemetry {
145145
for (let error of this._buffer) {
146146
/* __GDPR__
147147
"UnhandledError" : {
148-
"message" : { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth" },
149-
"name": { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth" },
150-
"stack": { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth" },
151-
"id": { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth" },
152-
"line": { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth" },
153-
"column": { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth" }
148+
"message" : { "classification": "CallstackOrException", "purpose": "PerformanceAndHealth" },
149+
"name": { "classification": "CallstackOrException", "purpose": "PerformanceAndHealth" },
150+
"stack": { "classification": "CallstackOrException", "purpose": "PerformanceAndHealth" },
151+
"id": { "classification": "CallstackOrException", "purpose": "PerformanceAndHealth" },
152+
"line": { "classification": "CallstackOrException", "purpose": "PerformanceAndHealth" },
153+
"column": { "classification": "CallstackOrException", "purpose": "PerformanceAndHealth" }
154154
}
155155
*/
156156
// __GDPR__TODO__ what's the complete set of properties?

‎src/vs/workbench/parts/cache/node/nodeCachedDataManager.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ export class NodeCachedDataManager implements IWorkbenchContribution {
3535
if (err) {
3636
/* __GDPR__
3737
"cachedDataError" : {
38-
"errorCode" : { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth" },
38+
"errorCode" : { "classification": "CallstackOrException", "purpose": "PerformanceAndHealth" },
3939
"path": { "classification": "CustomerContent", "purpose": "PerformanceAndHealth" }
4040
}
4141
*/

‎src/vs/workbench/parts/debug/electron-browser/debugService.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -955,7 +955,7 @@ export class DebugService implements debug.IDebugService {
955955
/* __GDPR__
956956
"debugMisconfiguration" : {
957957
"type" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
958-
"error": { "classification": "SystemMetaData", "purpose": "FeatureInsight" }
958+
"error": { "classification": "CallstackOrException", "purpose": "FeatureInsight" }
959959
}
960960
*/
961961
this.telemetryService.publicLog('debugMisconfiguration', { type: configuration ? configuration.type : undefined, error: errorMessage });

‎src/vs/workbench/parts/debug/electron-browser/rawDebugSession.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ export class RawDebugSession extends V8Protocol implements debug.ISession {
165165
if (error && error.sendTelemetry) {
166166
/* __GDPR__
167167
"debugProtocolErrorResponse" : {
168-
"error" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" }
168+
"error" : { "classification": "CallstackOrException", "purpose": "FeatureInsight" }
169169
}
170170
*/
171171
this.telemetryService.publicLog('debugProtocolErrorResponse', { error: telemetryMessage });

‎src/vs/workbench/parts/extensions/node/extensionsWorkbenchService.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -883,7 +883,7 @@ export class ExtensionsWorkbenchService implements IExtensionsWorkbenchService {
883883
"extensionGallery:install" : {
884884
"success": { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth" },
885885
"duration" : { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth" },
886-
"errorcode": { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth" },
886+
"errorcode": { "classification": "CallstackOrException", "purpose": "PerformanceAndHealth" },
887887
"recommendationReason": { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
888888
"${include}": [
889889
"${GalleryExtensionTelemetryData}"
@@ -894,7 +894,7 @@ export class ExtensionsWorkbenchService implements IExtensionsWorkbenchService {
894894
"extensionGallery:update" : {
895895
"success": { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth" },
896896
"duration" : { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth" },
897-
"errorcode": { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth" },
897+
"errorcode": { "classification": "CallstackOrException", "purpose": "PerformanceAndHealth" },
898898
"recommendationReason": { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
899899
"${include}": [
900900
"${GalleryExtensionTelemetryData}"
@@ -905,7 +905,7 @@ export class ExtensionsWorkbenchService implements IExtensionsWorkbenchService {
905905
"extensionGallery:uninstall" : {
906906
"success": { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth" },
907907
"duration" : { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth" },
908-
"errorcode": { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth" },
908+
"errorcode": { "classification": "CallstackOrException", "purpose": "PerformanceAndHealth" },
909909
"recommendationReason": { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
910910
"${include}": [
911911
"${GalleryExtensionTelemetryData}"

‎src/vs/workbench/parts/preferences/browser/preferencesEditor.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -618,7 +618,7 @@ class PreferencesRenderersController extends Disposable {
618618
} else {
619619
/* __GDPR__
620620
"defaultSettings.searchError" : {
621-
"message": { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
621+
"message": { "classification": "CallstackOrException", "purpose": "FeatureInsight" },
622622
"filter": { "classification": "SystemMetaData", "purpose": "FeatureInsight" }
623623
}
624624
*/

‎src/vs/workbench/parts/welcome/page/electron-browser/welcomePage.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -484,7 +484,7 @@ class WelcomePage {
484484
"from" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
485485
"extensionId": { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
486486
"outcome": { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
487-
"error": { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth" }
487+
"error": { "classification": "CallstackOrException", "purpose": "PerformanceAndHealth" }
488488
}
489489
*/
490490
this.telemetryService.publicLog(strings.installedEvent, {
@@ -519,7 +519,7 @@ class WelcomePage {
519519
"from" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
520520
"extensionId": { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
521521
"outcome": { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
522-
"error": { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth" }
522+
"error": { "classification": "CallstackOrException", "purpose": "PerformanceAndHealth" }
523523
}
524524
*/
525525
this.telemetryService.publicLog(strings.installedEvent, {

0 commit comments

Comments
 (0)