Only throw error if releaseNotesUrl doesn't exist

Charles-Gagnon · web-flow · commit 8bf38bb9d4d2 · 2020-07-10T11:15:45.000-07:00
diff --git a/src/vs/workbench/contrib/update/browser/update.ts b/src/vs/workbench/contrib/update/browser/update.ts
@@ -54,8 +54,9 @@ export class OpenLatestReleaseNotesInBrowserAction extends Action {
 		if (this.productService.releaseNotesUrl) {
 			const uri = URI.parse(this.productService.releaseNotesUrl);
 			await this.openerService.open(uri);
+		} else {
+			throw new Error('This version of Visual Studio Code does not have release notes online');
 		}
-		throw new Error('This version of Visual Studio Code does not have release notes online');
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -54,8 +54,9 @@ export class OpenLatestReleaseNotesInBrowserAction extends Action {`
`54`	`54`	`if (this.productService.releaseNotesUrl) {`
`55`	`55`	`const uri = URI.parse(this.productService.releaseNotesUrl);`
`56`	`56`	`await this.openerService.open(uri);`
	`57`	`+ } else {`
	`58`	`+ throw new Error('This version of Visual Studio Code does not have release notes online');`
`57`	`59`	`}`
`58`		`- throw new Error('This version of Visual Studio Code does not have release notes online');`
`59`	`60`	`}`
`60`	`61`	`}`
`61`	`62`