fix microsoft#97998. let the api throw.

rebornix · rebornix · commit 8bf295d57683 · 2020-06-26T10:43:50.000-07:00
diff --git a/src/vs/workbench/api/common/extHostNotebook.ts b/src/vs/workbench/api/common/extHostNotebook.ts
@@ -1151,12 +1151,7 @@ export class ExtHostNotebookController implements ExtHostNotebookShape, ExtHostN
 		}
 
 		if (this._notebookContentProviders.has(viewType)) {
-			try {
-				await this._notebookContentProviders.get(viewType)!.provider.saveNotebook(document, token);
-			} catch (e) {
-				return false;
-			}
-
+			await this._notebookContentProviders.get(viewType)!.provider.saveNotebook(document, token);
 			return true;
 		}
 
@@ -1170,12 +1165,7 @@ export class ExtHostNotebookController implements ExtHostNotebookShape, ExtHostN
 		}
 
 		if (this._notebookContentProviders.has(viewType)) {
-			try {
-				await this._notebookContentProviders.get(viewType)!.provider.saveNotebookAs(URI.revive(target), document, token);
-			} catch (e) {
-				return false;
-			}
-
+			await this._notebookContentProviders.get(viewType)!.provider.saveNotebookAs(URI.revive(target), document, token);
 			return true;
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -1151,12 +1151,7 @@ export class ExtHostNotebookController implements ExtHostNotebookShape, ExtHostN`
`1151`	`1151`	`}`
`1152`	`1152`
`1153`	`1153`	`if (this._notebookContentProviders.has(viewType)) {`
`1154`		`- try {`
`1155`		`- await this._notebookContentProviders.get(viewType)!.provider.saveNotebook(document, token);`
`1156`		`- } catch (e) {`
`1157`		`- return false;`
`1158`		`- }`
`1159`		`-`
	`1154`	`+ await this._notebookContentProviders.get(viewType)!.provider.saveNotebook(document, token);`
`1160`	`1155`	`return true;`
`1161`	`1156`	`}`
`1162`	`1157`
`@@ -1170,12 +1165,7 @@ export class ExtHostNotebookController implements ExtHostNotebookShape, ExtHostN`
`1170`	`1165`	`}`
`1171`	`1166`
`1172`	`1167`	`if (this._notebookContentProviders.has(viewType)) {`
`1173`		`- try {`
`1174`		`- await this._notebookContentProviders.get(viewType)!.provider.saveNotebookAs(URI.revive(target), document, token);`
`1175`		`- } catch (e) {`
`1176`		`- return false;`
`1177`		`- }`
`1178`		`-`
	`1168`	`+ await this._notebookContentProviders.get(viewType)!.provider.saveNotebookAs(URI.revive(target), document, token);`
`1179`	`1169`	`return true;`
`1180`	`1170`	`}`
`1181`	`1171`