rearrange z-index in titlebar

sbatten · sbatten · commit 8b57f402e0e3 · 2019-11-15T16:14:29.000-08:00
refs microsoft#84806
diff --git a/src/vs/workbench/browser/parts/titlebar/media/titlebarpart.css b/src/vs/workbench/browser/parts/titlebar/media/titlebarpart.css
@@ -33,7 +33,7 @@
 	 */
 	transform: translate3d(0px, 0px, 0px);
 	position: relative;
-	z-index: 1000;
+	z-index: 1000; // move the entire titlebar above the workbench, except modals/dialogs
 }
 
 .monaco-workbench .part.titlebar > .titlebar-drag-region {
@@ -43,10 +43,14 @@
 	position: absolute;
 	width: 100%;
 	height: 100%;
-	z-index: -1;
 	-webkit-app-region: drag;
 }
 
+.monaco-workbench .part.titlebar > .menubar {
+	// Move above drag region since negative z-index on that element causes AA issues
+	z-index: 1;
+}
+
 .monaco-workbench .part.titlebar > .window-title {
 	flex: 0 1 auto;
 	font-size: 12px;
@@ -97,7 +101,7 @@
 	width: 35px;
 	height: 100%;
 	position: relative;
-	z-index: 3000;
+	z-index: 2; // highest level of titlebar
 	background-image: url('code-icon.svg');
 	background-repeat: no-repeat;
 	background-position: center center;
@@ -115,7 +119,7 @@
 	flex-shrink: 0;
 	text-align: center;
 	position: relative;
-	z-index: 3000;
+	z-index: 2; // highest level of titlebar
 	-webkit-app-region: no-drag;
 	height: 100%;
 	width: 138px;
