Don't allow passing infinite=false to progressService

mjbvz · mjbvz · commit 8a3cae3edd83 · 2019-01-08T14:31:05.000-08:00
This state is currently unused and make no sense. Update the signature to  prevent ever trying to go into this state
diff --git a/src/vs/editor/standalone/browser/simpleServices.ts b/src/vs/editor/standalone/browser/simpleServices.ts
@@ -139,7 +139,7 @@ export class SimpleProgressService implements IProgressService {
 		worked: () => { }
 	};
 
-	show(infinite: boolean, delay?: number): IProgressRunner;
+	show(infinite: true, delay?: number): IProgressRunner;
 	show(total: number, delay?: number): IProgressRunner;
 	show(): IProgressRunner {
 		return SimpleProgressService.NULL_PROGRESS_RUNNER;
diff --git a/src/vs/platform/progress/common/progress.ts b/src/vs/platform/progress/common/progress.ts
@@ -15,7 +15,7 @@ export interface IProgressService {
 	/**
 	 * Show progress customized with the provided flags.
 	 */
-	show(infinite: boolean, delay?: number): IProgressRunner;
+	show(infinite: true, delay?: number): IProgressRunner;
 	show(total: number, delay?: number): IProgressRunner;
 
 	/**
diff --git a/src/vs/workbench/services/progress/browser/progressService.ts b/src/vs/workbench/services/progress/browser/progressService.ts
@@ -127,7 +127,7 @@ export class ScopedProgressService extends ScopedService implements IProgressSer
 		}
 
 		// Replay Infinite Progress
-		else if (this.progressState.type === ProgressState.Infinite.type) {
+		else if (this.progressState.type === ProgressState.Type.Infinite) {
 			this.progressbar.infinite().show();
 		}
 
@@ -143,9 +143,9 @@ export class ScopedProgressService extends ScopedService implements IProgressSer
 		}
 	}
 
-	show(infinite: boolean, delay?: number): IProgressRunner;
+	show(infinite: true, delay?: number): IProgressRunner;
 	show(total: number, delay?: number): IProgressRunner;
-	show(infiniteOrTotal: boolean | number, delay?: number): IProgressRunner {
+	show(infiniteOrTotal: true | number, delay?: number): IProgressRunner {
 		// Sort out Arguments
 		if (typeof infiniteOrTotal === 'boolean') {
 			this.progressState = ProgressState.Infinite;
@@ -157,7 +157,7 @@ export class ScopedProgressService extends ScopedService implements IProgressSer
 		if (this.isActive) {
 
 			// Infinite: Start Progressbar and Show after Delay
-			if (this.progressState.type === ProgressState.Infinite.type) {
+			if (this.progressState.type === ProgressState.Type.Infinite) {
 				this.progressbar.infinite().show(delay);
 			}
 
@@ -252,9 +252,9 @@ export class ProgressService implements IProgressService {
 
 	constructor(private progressbar: ProgressBar) { }
 
-	show(infinite: boolean, delay?: number): IProgressRunner;
+	show(infinite: true, delay?: number): IProgressRunner;
 	show(total: number, delay?: number): IProgressRunner;
-	show(infiniteOrTotal: boolean | number, delay?: number): IProgressRunner {
+	show(infiniteOrTotal: true | number, delay?: number): IProgressRunner {
 		if (typeof infiniteOrTotal === 'boolean') {
 			this.progressbar.infinite().show(delay);
 		} else {
