Skip to content

Commit 88c8bfe

Browse files
committed
Fix microsoft#99241. Deleted cells info in cells change event. Re microsoft#93265.
1 parent 1eac96d commit 88c8bfe

2 files changed

Lines changed: 5 additions & 1 deletion

File tree

src/vs/vscode.proposed.d.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1534,6 +1534,7 @@ declare module 'vscode' {
15341534
export interface NotebookCellsChangeData {
15351535
readonly start: number;
15361536
readonly deletedCount: number;
1537+
readonly deletedItems: NotebookCell[];
15371538
readonly items: NotebookCell[];
15381539
}
15391540

src/vs/workbench/api/common/extHostNotebook.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -315,11 +315,12 @@ export class ExtHostNotebookDocument extends Disposable implements vscode.Notebo
315315

316316
}
317317

318-
this.cells.splice(splice[0], splice[1], ...newCells);
318+
const deletedItems = this.cells.splice(splice[0], splice[1], ...newCells);
319319

320320
const event: vscode.NotebookCellsChangeData = {
321321
start: splice[0],
322322
deletedCount: splice[1],
323+
deletedItems,
323324
items: newCells
324325
};
325326

@@ -340,10 +341,12 @@ export class ExtHostNotebookDocument extends Disposable implements vscode.Notebo
340341
const changes: vscode.NotebookCellsChangeData[] = [{
341342
start: index,
342343
deletedCount: 1,
344+
deletedItems: cells,
343345
items: []
344346
}, {
345347
start: newIdx,
346348
deletedCount: 0,
349+
deletedItems: [],
347350
items: cells
348351
}];
349352
this._emitter.emitModelChange({

0 commit comments

Comments
 (0)