Fix lifecycle tracking for toDisposable

mjbvz · mjbvz · commit 880eb7cd9a0c · 2019-07-10T15:38:04.000-07:00
diff --git a/src/vs/base/common/lifecycle.ts b/src/vs/base/common/lifecycle.ts
@@ -81,7 +81,13 @@ export function combinedDisposable(...disposables: IDisposable[]): IDisposable {
 }
 
 export function toDisposable(fn: () => void): IDisposable {
-	return trackDisposable({ dispose: fn });
+	const self = trackDisposable({
+		dispose: () => {
+			markTracked(self);
+			fn();
+		}
+	});
+	return self;
 }
 
 export class DisposableStore implements IDisposable {

Original file line number	Diff line number	Diff line change
`@@ -81,7 +81,13 @@ export function combinedDisposable(...disposables: IDisposable[]): IDisposable {`
`81`	`81`	`}`
`82`	`82`
`83`	`83`	`export function toDisposable(fn: () => void): IDisposable {`
`84`		`- return trackDisposable({ dispose: fn });`
	`84`	`+ const self = trackDisposable({`
	`85`	`+ dispose: () => {`
	`86`	`+ markTracked(self);`
	`87`	`+ fn();`
	`88`	`+ }`
	`89`	`+ });`
	`90`	`+ return self;`
`85`	`91`	`}`
`86`	`92`
`87`	`93`	`export class DisposableStore implements IDisposable {`