Skip to content

Commit 8701c52

Browse files
ramya-rao-aramya-rao-a
committed
Update GDPR classification
1 parent 1ec4b81 commit 8701c52

4 files changed

Lines changed: 11 additions & 5 deletions

File tree

‎src/vs/platform/telemetry/browser/errorTelemetry.ts‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -143,6 +143,9 @@ export default class ErrorTelemetry {
143143

144144
private _flushBuffer(): void {
145145
for (let error of this._buffer) {
146+
delete error.count;
147+
delete error.filename;
148+
146149
/* __GDPR__
147150
"UnhandledError" : {
148151
"message" : { "classification": "CallstackOrException", "purpose": "PerformanceAndHealth" },

‎src/vs/workbench/parts/extensions/node/extensionsWorkbenchService.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -925,7 +925,7 @@ export class ExtensionsWorkbenchService implements IExtensionsWorkbenchService {
925925
"success": { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth", "isMeasurement": true },
926926
"duration" : { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth", "isMeasurement": true },
927927
"errorcode": { "classification": "CallstackOrException", "purpose": "PerformanceAndHealth" },
928-
"recommendationReason": { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
928+
"recommendationReason": { "classification": "SystemMetaData", "purpose": "FeatureInsight", "isMeasurement": true },
929929
"${include}": [
930930
"${GalleryExtensionTelemetryData}"
931931
]
@@ -936,7 +936,7 @@ export class ExtensionsWorkbenchService implements IExtensionsWorkbenchService {
936936
"success": { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth", "isMeasurement": true },
937937
"duration" : { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth", "isMeasurement": true },
938938
"errorcode": { "classification": "CallstackOrException", "purpose": "PerformanceAndHealth" },
939-
"recommendationReason": { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
939+
"recommendationReason": { "classification": "SystemMetaData", "purpose": "FeatureInsight", "isMeasurement": true },
940940
"${include}": [
941941
"${GalleryExtensionTelemetryData}"
942942
]
@@ -947,7 +947,7 @@ export class ExtensionsWorkbenchService implements IExtensionsWorkbenchService {
947947
"success": { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth", "isMeasurement": true },
948948
"duration" : { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth", "isMeasurement": true },
949949
"errorcode": { "classification": "CallstackOrException", "purpose": "PerformanceAndHealth" },
950-
"recommendationReason": { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
950+
"recommendationReason": { "classification": "SystemMetaData", "purpose": "FeatureInsight", "isMeasurement": true },
951951
"${include}": [
952952
"${GalleryExtensionTelemetryData}"
953953
]

‎src/vs/workbench/parts/preferences/browser/preferencesEditor.ts‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -348,8 +348,10 @@ export class PreferencesEditor extends BaseEditor {
348348
/* __GDPR__
349349
"defaultSettings.filter" : {
350350
"filter": { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
351-
"durations" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
352-
"counts" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
351+
"durations.nlpresult" : { "classification": "SystemMetaData", "purpose": "FeatureInsight", "isMeasurement": true },
352+
"counts.nlpresult" : { "classification": "SystemMetaData", "purpose": "FeatureInsight", "isMeasurement": true },
353+
"durations.filterresult" : { "classification": "SystemMetaData", "purpose": "FeatureInsight", "isMeasurement": true },
354+
"counts.filterresult" : { "classification": "SystemMetaData", "purpose": "FeatureInsight", "isMeasurement": true },
353355
"requestCount" : { "classification": "SystemMetaData", "purpose": "FeatureInsight", "isMeasurement": true }
354356
}
355357
*/

‎src/vs/workbench/services/timer/common/timerService.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ export interface IMemoryInfo {
3737
"timers.ellapsedEditorRestore" : { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth", "isMeasurement": true },
3838
"timers.ellapsedWorkbench" : { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth", "isMeasurement": true },
3939
"timers.ellapsedTimersToTimersComputed" : { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth", "isMeasurement": true },
40+
"timers.ellapsedNlsGeneration" : { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth", "isMeasurement": true },
4041
"platform" : { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth" },
4142
"release" : { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth" },
4243
"arch" : { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth" },

0 commit comments

Comments
 (0)