Merge pull request microsoft#88714 from GabeDeBacker/user/gabrield/throwExceptionOnExtensionInstallFail

sandy081 · web-flow · commit 856a5ad8ad2f · 2020-01-24T21:58:36.000+01:00
Allows extension install and uninstall command execution to throw exceptions back to caller
diff --git a/src/vs/workbench/contrib/extensions/browser/extensions.contribution.ts b/src/vs/workbench/contrib/extensions/browser/extensions.contribution.ts
@@ -252,6 +252,7 @@ CommandsRegistry.registerCommand({
 			}
 		} catch (e) {
 			onUnexpectedError(e);
+			throw e;
 		}
 	}
 });
@@ -284,6 +285,7 @@ CommandsRegistry.registerCommand({
 			await extensionManagementService.uninstall(extensionToUninstall, true);
 		} catch (e) {
 			onUnexpectedError(e);
+			throw e;
 		}
 	}
 });

Original file line number	Diff line number	Diff line change
`@@ -252,6 +252,7 @@ CommandsRegistry.registerCommand({`
`252`	`252`	`}`
`253`	`253`	`} catch (e) {`
`254`	`254`	`onUnexpectedError(e);`
	`255`	`+ throw e;`
`255`	`256`	`}`
`256`	`257`	`}`
`257`	`258`	`});`
`@@ -284,6 +285,7 @@ CommandsRegistry.registerCommand({`
`284`	`285`	`await extensionManagementService.uninstall(extensionToUninstall, true);`
`285`	`286`	`} catch (e) {`
`286`	`287`	`onUnexpectedError(e);`
	`288`	`+ throw e;`
`287`	`289`	`}`
`288`	`290`	`}`
`289`	`291`	`});`