remove product.welcomePage

Benjamin Pasero · Benjamin Pasero · commit 84391a4685d6 · 2019-10-03T10:20:19.000+02:00
diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "code-oss-dev",
   "version": "1.39.0",
-  "distro": "967a5f6fb3ab3baa4f996b757db7312f81df41b5",
+  "distro": "b9bb6392c20ba05a247e41ea75b2825544fd8afd",
   "author": {
     "name": "Microsoft Corporation"
   },
diff --git a/src/vs/platform/product/common/productService.ts b/src/vs/platform/product/common/productService.ts
@@ -56,8 +56,6 @@ export interface IProductConfiguration {
 		readonly productName: string;
 	};
 
-	readonly welcomePage?: string;
-
 	readonly enableTelemetry?: boolean;
 	readonly aiConfig?: {
 		readonly asimovKey: string;
diff --git a/src/vs/workbench/contrib/welcome/gettingStarted/electron-browser/gettingStarted.contribution.ts b/src/vs/workbench/contrib/welcome/gettingStarted/electron-browser/gettingStarted.contribution.ts
@@ -7,7 +7,5 @@ import { Registry } from 'vs/platform/registry/common/platform';
 import { IWorkbenchContributionsRegistry, Extensions as WorkbenchExtensions } from 'vs/workbench/common/contributions';
 import { LifecyclePhase } from 'vs/platform/lifecycle/common/lifecycle';
 import { NativeTelemetryOptOut } from 'vs/workbench/contrib/welcome/gettingStarted/electron-browser/telemetryOptOut';
-import { OpenWelcomePageInBrowser } from 'vs/workbench/contrib/welcome/gettingStarted/electron-browser/openWebsite';
 
-Registry.as<IWorkbenchContributionsRegistry>(WorkbenchExtensions.Workbench).registerWorkbenchContribution(OpenWelcomePageInBrowser, LifecyclePhase.Restored);
 Registry.as<IWorkbenchContributionsRegistry>(WorkbenchExtensions.Workbench).registerWorkbenchContribution(NativeTelemetryOptOut, LifecyclePhase.Eventually);
diff --git a/src/vs/workbench/contrib/welcome/gettingStarted/electron-browser/openWebsite.ts b/src/vs/workbench/contrib/welcome/gettingStarted/electron-browser/openWebsite.ts
diff --git a/src/vs/workbench/services/environment/browser/environmentService.ts b/src/vs/workbench/services/environment/browser/environmentService.ts
@@ -170,7 +170,6 @@ export class BrowserWorkbenchEnvironmentService implements IWorkbenchEnvironment
 	log?: string;
 	logsPath: string;
 	verbose: boolean;
-	skipGettingStarted: boolean;
 	skipReleaseNotes: boolean;
 	mainIPCHandle: string;
 	sharedIPCHandle: string;
diff --git a/src/vs/workbench/services/environment/common/environmentService.ts b/src/vs/workbench/services/environment/common/environmentService.ts
@@ -28,7 +28,6 @@ export interface IWorkbenchEnvironmentService extends IEnvironmentService {
 	readonly webviewResourceRoot: string;
 	readonly webviewCspSource: string;
 
-	readonly skipGettingStarted: boolean | undefined;
 	readonly skipReleaseNotes: boolean | undefined;
 
 }
diff --git a/src/vs/workbench/services/environment/node/environmentService.ts b/src/vs/workbench/services/environment/node/environmentService.ts
@@ -36,8 +36,6 @@ export class WorkbenchEnvironmentService extends EnvironmentService implements I
 		this.configuration.backupWorkspaceResource = this.configuration.backupPath ? toBackupWorkspaceResource(this.configuration.backupPath, this) : undefined;
 	}
 
-	get skipGettingStarted(): boolean { return !!this.args['skip-getting-started']; }
-
 	get skipReleaseNotes(): boolean { return !!this.args['skip-release-notes']; }
 
 	@memoize

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "code-oss-dev",`
`3`	`3`	`"version": "1.39.0",`
`4`		`- "distro": "967a5f6fb3ab3baa4f996b757db7312f81df41b5",`
	`4`	`+ "distro": "b9bb6392c20ba05a247e41ea75b2825544fd8afd",`
`5`	`5`	`"author": {`
`6`	`6`	`"name": "Microsoft Corporation"`
`7`	`7`	`},`
Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,6 @@ export interface IWorkbenchEnvironmentService extends IEnvironmentService {`
`28`	`28`	`readonly webviewResourceRoot: string;`
`29`	`29`	`readonly webviewCspSource: string;`
`30`	`30`
`31`		`- readonly skipGettingStarted: boolean \| undefined;`
`32`	`31`	`readonly skipReleaseNotes: boolean \| undefined;`
`33`	`32`
`34`	`33`	`}`
Original file line number	Diff line number	Diff line change
`@@ -36,8 +36,6 @@ export class WorkbenchEnvironmentService extends EnvironmentService implements I`
`36`	`36`	`this.configuration.backupWorkspaceResource = this.configuration.backupPath ? toBackupWorkspaceResource(this.configuration.backupPath, this) : undefined;`
`37`	`37`	`}`
`38`	`38`
`39`		`- get skipGettingStarted(): boolean { return !!this.args['skip-getting-started']; }`
`40`		`-`
`41`	`39`	`get skipReleaseNotes(): boolean { return !!this.args['skip-release-notes']; }`
`42`	`40`
`43`	`41`	`@memoize`