list: optional renderer.disposeElement

joaomoreno · joaomoreno · commit 831da61a7a7b · 2018-07-10T18:15:21.000+02:00
diff --git a/src/vs/base/browser/ui/list/list.ts b/src/vs/base/browser/ui/list/list.ts
@@ -14,6 +14,7 @@ export interface IRenderer<TElement, TTemplateData> {
 	templateId: string;
 	renderTemplate(container: HTMLElement): TTemplateData;
 	renderElement(element: TElement, index: number, templateData: TTemplateData): void;
+	disposeElement?(element: TElement, index: number, templateData: TTemplateData): void;
 	disposeTemplate(templateData: TTemplateData): void;
 }
 
diff --git a/src/vs/base/browser/ui/list/listView.ts b/src/vs/base/browser/ui/list/listView.ts
@@ -322,6 +322,12 @@ export class ListView<T> implements ISpliceable<T>, IDisposable {
 			throw new Error(`Got index ${index} and there are ${this.items.length} items. File issue to joao!`);
 		}
 
+		const renderer = this.renderers.get(item.templateId);
+
+		if (renderer.disposeElement) {
+			renderer.disposeElement(item.element, index, item.row.templateData);
+		}
+
 		this.cache.release(item.row);
 		item.row = null;
 	}

Original file line number	Diff line number	Diff line change
`@@ -14,6 +14,7 @@ export interface IRenderer<TElement, TTemplateData> {`
`14`	`14`	`templateId: string;`
`15`	`15`	`renderTemplate(container: HTMLElement): TTemplateData;`
`16`	`16`	`renderElement(element: TElement, index: number, templateData: TTemplateData): void;`
	`17`	`+ disposeElement?(element: TElement, index: number, templateData: TTemplateData): void;`
`17`	`18`	`disposeTemplate(templateData: TTemplateData): void;`
`18`	`19`	`}`
`19`	`20`
Original file line number	Diff line number	Diff line change
`@@ -322,6 +322,12 @@ export class ListView<T> implements ISpliceable<T>, IDisposable {`
`322`	`322`	throw new Error(`Got index ${index} and there are ${this.items.length} items. File issue to joao!`);
`323`	`323`	`}`
`324`	`324`
	`325`	`+ const renderer = this.renderers.get(item.templateId);`
	`326`	`+`
	`327`	`+ if (renderer.disposeElement) {`
	`328`	`+ renderer.disposeElement(item.element, index, item.row.templateData);`
	`329`	`+ }`
	`330`	`+`
`325`	`331`	`this.cache.release(item.row);`
`326`	`332`	`item.row = null;`
`327`	`333`	`}`