Respect thisArg in EnvironmentVariableCollection.forEach

Tyriar · Tyriar · commit 8279cc70d9d5 · 2020-04-09T06:05:34.000-07:00
Fixes microsoft#94077
diff --git a/src/vs/workbench/api/common/extHostTerminalService.ts b/src/vs/workbench/api/common/extHostTerminalService.ts
@@ -692,7 +692,7 @@ export class EnvironmentVariableCollection implements vscode.EnvironmentVariable
 
 	forEach(callback: (variable: string, mutator: vscode.EnvironmentVariableMutator, collection: vscode.EnvironmentVariableCollection) => any, thisArg?: any): void {
 		this._checkDisposed();
-		this.map.forEach((value, key) => callback(key, value, this));
+		this.map.forEach((value, key) => callback.call(thisArg, key, value, this));
 	}
 
 	delete(variable: string): void {

Original file line number	Diff line number	Diff line change
`@@ -692,7 +692,7 @@ export class EnvironmentVariableCollection implements vscode.EnvironmentVariable`
`692`	`692`
`693`	`693`	`forEach(callback: (variable: string, mutator: vscode.EnvironmentVariableMutator, collection: vscode.EnvironmentVariableCollection) => any, thisArg?: any): void {`
`694`	`694`	`this._checkDisposed();`
`695`		`- this.map.forEach((value, key) => callback(key, value, this));`
	`695`	`+ this.map.forEach((value, key) => callback.call(thisArg, key, value, this));`
`696`	`696`	`}`
`697`	`697`
`698`	`698`	`delete(variable: string): void {`