microsoft#70254 - Set astrisk as a delimiter for URIs (microsoft#82816)

alexdima · web-flow · commit 820b2f6ec52a · 2019-10-24T11:11:00.000+02:00
microsoft#70254 - Set astrisk as a delimiter for URIs
diff --git a/src/vs/editor/common/modes/linkComputer.ts b/src/vs/editor/common/modes/linkComputer.ts
@@ -264,6 +264,10 @@ export class LinkComputer {
 						case CharCode.BackTick:
 							chClass = (linkBeginChCode === CharCode.SingleQuote || linkBeginChCode === CharCode.DoubleQuote) ? CharacterClass.None : CharacterClass.ForceTermination;
 							break;
+						case CharCode.Asterisk:
+							// `*` terminates a link if the link began with `*`
+							chClass = (linkBeginChCode === CharCode.Asterisk) ? CharacterClass.ForceTermination : CharacterClass.None;
+							break;
 						default:
 							chClass = classifier.get(chCode);
 					}
diff --git a/src/vs/editor/test/common/modes/linkComputer.test.ts b/src/vs/editor/test/common/modes/linkComputer.test.ts
@@ -202,4 +202,11 @@ suite('Editor Modes - Link Computer', () => {
 			'         http://[::1]:5000/connect/token  '
 		);
 	});
+
+	test('issue #70254: bold links dont open in markdown file using editor mode with ctrl + click', () => {
+		assertLink(
+			'2. Navigate to **https://portal.azure.com**',
+			'                 https://portal.azure.com  '
+		);
+	});
 });
