Return result directly instead of mutating var

mjbvz · mjbvz · commit 7f96c0cc4afb · 2019-09-13T17:44:10.000-07:00
diff --git a/src/vs/workbench/contrib/files/common/editors/fileEditorInput.ts b/src/vs/workbench/contrib/files/common/editors/fileEditorInput.ts
@@ -192,24 +192,16 @@ export class FileEditorInput extends EditorInput implements IFileEditorInput {
 	}
 
 	getTitle(verbosity: Verbosity): string {
-		let title: string;
 		switch (verbosity) {
 			case Verbosity.SHORT:
-				title = this.shortTitle;
 				// already decorated by getName()
-				break;
+				return this.shortTitle;
 			default:
 			case Verbosity.MEDIUM:
-				title = this.mediumTitle;
-				title = this.decorateLabel(title);
-				break;
+				return this.decorateLabel(this.mediumTitle);
 			case Verbosity.LONG:
-				title = this.longTitle;
-				title = this.decorateLabel(title);
-				break;
+				return this.decorateLabel(this.longTitle);
 		}
-
-		return title;
 	}
 
 	private decorateLabel(label: string): string {
