Revert "fix strict null errors"

aeschli · aeschli · commit 7f58924aae18 · 2018-10-22T12:59:21.000+02:00
This reverts commit 9ea18e6.
diff --git a/src/tsconfig.strictNullChecks.json b/src/tsconfig.strictNullChecks.json
@@ -431,7 +431,6 @@
 		"./vs/platform/update/node/update.config.contribution.ts",
 		"./vs/platform/url/common/url.ts",
 		"./vs/platform/url/common/urlService.ts",
-		"./vs/platform/windows/common/windows.ts",
 		"./vs/platform/workbench/common/contextkeys.ts",
 		"./vs/platform/workspace/common/workspace.ts",
 		"./vs/platform/workspace/test/common/testWorkspace.ts",
diff --git a/src/vs/platform/storage/common/storage.ts b/src/vs/platform/storage/common/storage.ts
@@ -30,7 +30,7 @@ export interface IStorageService {
 	 * The scope argument allows to define the scope of the storage
 	 * operation to either the current workspace only or all workspaces.
 	 */
-	get<R extends string | undefined>(key: string, scope: StorageScope, fallbackValue?: R): R;
+	get(key: string, scope: StorageScope, fallbackValue?: string): string | undefined;
 
 	/**
 	 * Retrieve an element stored with the given key from storage. Use
@@ -40,7 +40,7 @@ export interface IStorageService {
 	 * The scope argument allows to define the scope of the storage
 	 * operation to either the current workspace only or all workspaces.
 	 */
-	getBoolean<R extends boolean | undefined>(key: string, scope: StorageScope, fallbackValue?: R): R;
+	getBoolean(key: string, scope: StorageScope, fallbackValue?: boolean): boolean | undefined;
 
 	/**
 	 * Retrieve an element stored with the given key from storage. Use
@@ -50,7 +50,7 @@ export interface IStorageService {
 	 * The scope argument allows to define the scope of the storage
 	 * operation to either the current workspace only or all workspaces.
 	 */
-	getInteger<R extends number | undefined>(key: string, scope: StorageScope, fallbackValue?: R): R;
+	getInteger(key: string, scope: StorageScope, fallbackValue?: number): number | undefined;
 
 	/**
 	 * Store a string value under the given key to storage. The value will
@@ -94,16 +94,16 @@ export const NullStorageService: IStorageService = {
 	onDidChangeStorage: Event.None,
 	onWillSaveState: Event.None,
 
-	get<R extends string | undefined>(key: string, scope: StorageScope, fallbackValue?: R): R {
-		return fallbackValue as R;
+	get(key: string, scope: StorageScope, fallbackValue?: string): string | undefined {
+		return fallbackValue;
 	},
 
-	getBoolean<R extends boolean | undefined>(key: string, scope: StorageScope, fallbackValue?: R): R {
-		return fallbackValue as R;
+	getBoolean(key: string, scope: StorageScope, fallbackValue?: boolean): boolean | undefined {
+		return fallbackValue;
 	},
 
-	getInteger<R extends number | undefined>(key: string, scope: StorageScope, fallbackValue?: R): R {
-		return fallbackValue as R;
+	getInteger(key: string, scope: StorageScope, fallbackValue?: number): number | undefined {
+		return fallbackValue;
 	},
 
 	store(key: string, value: any, scope: StorageScope): Promise<void> {
diff --git a/src/vs/platform/windows/common/windows.ts b/src/vs/platform/windows/common/windows.ts
@@ -379,7 +379,7 @@ export class ActiveWindowManager implements IDisposable {
 			.then(id => (typeof this._activeWindowId === 'undefined') && this.setActiveWindow(id));
 	}
 
-	private setActiveWindow(windowId: number | undefined) {
+	private setActiveWindow(windowId: number) {
 		if (this.firstActiveWindowIdPromise) {
 			this.firstActiveWindowIdPromise = null;
 		}

Original file line number	Diff line number	Diff line change
`@@ -379,7 +379,7 @@ export class ActiveWindowManager implements IDisposable {`
`379`	`379`	`.then(id => (typeof this._activeWindowId === 'undefined') && this.setActiveWindow(id));`
`380`	`380`	`}`
`381`	`381`
`382`		`- private setActiveWindow(windowId: number \| undefined) {`
	`382`	`+ private setActiveWindow(windowId: number) {`
`383`	`383`	`if (this.firstActiveWindowIdPromise) {`
`384`	`384`	`this.firstActiveWindowIdPromise = null;`
`385`	`385`	`}`