debug: seperator in launch drop down

isidorn · isidorn · commit 7f0bff825e7d · 2017-01-12T16:50:58.000+01:00
diff --git a/src/vs/base/browser/ui/selectBox/selectBox.ts b/src/vs/base/browser/ui/selectBox/selectBox.ts
@@ -40,13 +40,14 @@ export class SelectBox extends Widget {
 		return this._onDidSelect.event;
 	}
 
-	public setOptions(options: string[], selected?: number): void {
+	public setOptions(options: string[], selected?: number, disabled?: number): void {
 		if (!this.options || !arrays.equals(this.options, options)) {
 			this.options = options;
 
 			this.selectElement.options.length = 0;
+			let i = 0;
 			this.options.forEach((option) => {
-				this.selectElement.add(this.createOption(option));
+				this.selectElement.add(this.createOption(option, disabled === i++));
 			});
 		}
 		this.select(selected);
@@ -91,10 +92,11 @@ export class SelectBox extends Widget {
 		this.setOptions(this.options, this.selected);
 	}
 
-	private createOption(value: string): HTMLOptionElement {
+	private createOption(value: string, disabled?: boolean): HTMLOptionElement {
 		let option = document.createElement('option');
 		option.value = value;
 		option.text = value;
+		option.disabled = disabled;
 
 		return option;
 	}
diff --git a/src/vs/workbench/parts/debug/browser/debugActionItems.ts b/src/vs/workbench/parts/debug/browser/debugActionItems.ts
@@ -22,6 +22,7 @@ const $ = dom.$;
 export class StartDebugActionItem extends EventEmitter implements IActionItem {
 
 	private static ADD_CONFIGURATION = nls.localize('addConfiguration', "Add Configuration...");
+	private static SEPARATOR = '─────────';
 
 	public actionRunner: IActionRunner;
 	private container: HTMLElement;
@@ -132,8 +133,9 @@ export class StartDebugActionItem extends EventEmitter implements IActionItem {
 		} else {
 			this.setEnabled(true);
 			const selected = options.indexOf(this.debugService.getViewModel().selectedConfigurationName);
+			options.push(StartDebugActionItem.SEPARATOR);
 			options.push(StartDebugActionItem.ADD_CONFIGURATION);
-			this.selectBox.setOptions(options, selected);
+			this.selectBox.setOptions(options, selected, options.length - 2);
 		}
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -22,6 +22,7 @@ const $ = dom.$;`
`22`	`22`	`export class StartDebugActionItem extends EventEmitter implements IActionItem {`
`23`	`23`
`24`	`24`	`private static ADD_CONFIGURATION = nls.localize('addConfiguration', "Add Configuration...");`
	`25`	`+ private static SEPARATOR = '─────────';`
`25`	`26`
`26`	`27`	`public actionRunner: IActionRunner;`
`27`	`28`	`private container: HTMLElement;`
`@@ -132,8 +133,9 @@ export class StartDebugActionItem extends EventEmitter implements IActionItem {`
`132`	`133`	`} else {`
`133`	`134`	`this.setEnabled(true);`
`134`	`135`	`const selected = options.indexOf(this.debugService.getViewModel().selectedConfigurationName);`
	`136`	`+ options.push(StartDebugActionItem.SEPARATOR);`
`135`	`137`	`options.push(StartDebugActionItem.ADD_CONFIGURATION);`
`136`		`- this.selectBox.setOptions(options, selected);`
	`138`	`+ this.selectBox.setOptions(options, selected, options.length - 2);`
`137`	`139`	`}`
`138`	`140`	`}`
`139`	`141`	`}`