Skip to content

Commit 7eb690f

Browse files
committed
debt - remove getCommandActions as there is now an explicit command palette menu
1 parent 69fdfa2 commit 7eb690f

3 files changed

Lines changed: 2 additions & 14 deletions

File tree

src/vs/editor/browser/standalone/simpleServices.ts

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,7 @@ import { IDisposable, IReference, ImmortalReference, combinedDisposable } from '
2828
import * as dom from 'vs/base/browser/dom';
2929
import { StandardKeyboardEvent } from 'vs/base/browser/keyboardEvent';
3030
import { KeybindingsRegistry } from 'vs/platform/keybinding/common/keybindingsRegistry';
31-
import { values } from 'vs/base/common/collections';
32-
import { MenuId, MenuRegistry, ICommandAction, IMenu, IMenuService } from 'vs/platform/actions/common/actions';
31+
import { MenuId, IMenu, IMenuService } from 'vs/platform/actions/common/actions';
3332
import { Menu } from 'vs/platform/actions/common/menu';
3433
import { ITelemetryService, ITelemetryExperiments, ITelemetryInfo } from 'vs/platform/telemetry/common/telemetry';
3534

@@ -428,10 +427,6 @@ export class SimpleMenuService implements IMenuService {
428427
public createMenu(id: MenuId, contextKeyService: IContextKeyService): IMenu {
429428
return new Menu(id, TPromise.as(true), this._commandService, contextKeyService);
430429
}
431-
432-
public getCommandActions(): ICommandAction[] {
433-
return values(MenuRegistry.commands);
434-
}
435430
}
436431

437432
export class StandaloneTelemetryService implements ITelemetryService {

src/vs/platform/actions/common/actions.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,8 +67,6 @@ export interface IMenuService {
6767
_serviceBrand: any;
6868

6969
createMenu(id: MenuId, scopedKeybindingService: IContextKeyService): IMenu;
70-
71-
getCommandActions(): ICommandAction[];
7270
}
7371

7472
export interface IMenuRegistry {

src/vs/platform/actions/common/menuService.ts

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,8 @@
55

66
'use strict';
77

8-
import { values } from 'vs/base/common/collections';
98
import { IContextKeyService } from 'vs/platform/contextkey/common/contextkey';
10-
import { MenuId, MenuRegistry, ICommandAction, IMenu, IMenuService } from 'vs/platform/actions/common/actions';
9+
import { MenuId, IMenu, IMenuService } from 'vs/platform/actions/common/actions';
1110
import { Menu } from 'vs/platform/actions/common/menu';
1211
import { IExtensionService } from 'vs/platform/extensions/common/extensions';
1312
import { ICommandService } from 'vs/platform/commands/common/commands';
@@ -26,8 +25,4 @@ export class MenuService implements IMenuService {
2625
createMenu(id: MenuId, contextKeyService: IContextKeyService): IMenu {
2726
return new Menu(id, this._extensionService.onReady(), this._commandService, contextKeyService);
2827
}
29-
30-
getCommandActions(): ICommandAction[] {
31-
return values(MenuRegistry.commands);
32-
}
3328
}

0 commit comments

Comments
 (0)