avoid iconClassName

aeschli · aeschli · commit 7e38e22cd1fd · 2020-04-22T17:32:15.000+02:00
diff --git a/src/vs/base/browser/ui/tree/asyncDataTree.ts b/src/vs/base/browser/ui/tree/asyncDataTree.ts
@@ -15,7 +15,7 @@ import { Iterable } from 'vs/base/common/iterator';
 import { IDragAndDropData } from 'vs/base/browser/dnd';
 import { ElementsDragAndDropData } from 'vs/base/browser/ui/list/listView';
 import { isPromiseCanceledError, onUnexpectedError } from 'vs/base/common/errors';
-import { toggleClass } from 'vs/base/browser/dom';
+import { removeClasses, addClasses } from 'vs/base/browser/dom';
 import { values } from 'vs/base/common/map';
 import { ScrollEvent } from 'vs/base/common/scrollable';
 import { ICompressedTreeNode, ICompressedTreeElement } from 'vs/base/browser/ui/tree/compressedObjectTreeModel';
@@ -110,7 +110,11 @@ class AsyncDataTreeRenderer<TInput, T, TFilterData, TTemplateData> implements IT
 	}
 
 	renderTwistie(element: IAsyncDataTreeNode<TInput, T>, twistieElement: HTMLElement): boolean {
-		toggleClass(twistieElement, treeItemLoadingIcon.iconClassName, element.slow);
+		if (element.slow) {
+			addClasses(twistieElement, treeItemLoadingIcon.classNames);
+		} else {
+			removeClasses(twistieElement, treeItemLoadingIcon.classNames);
+		}
 		return false;
 	}
 
@@ -1039,7 +1043,11 @@ class CompressibleAsyncDataTreeRenderer<TInput, T, TFilterData, TTemplateData> i
 	}
 
 	renderTwistie(element: IAsyncDataTreeNode<TInput, T>, twistieElement: HTMLElement): boolean {
-		toggleClass(twistieElement, treeItemLoadingIcon.iconClassName, element.slow);
+		if (element.slow) {
+			addClasses(twistieElement, treeItemLoadingIcon.classNames);
+		} else {
+			removeClasses(twistieElement, treeItemLoadingIcon.classNames);
+		}
 		return false;
 	}
 
diff --git a/src/vs/base/common/codicons.ts b/src/vs/base/common/codicons.ts
@@ -53,7 +53,6 @@ export class Codicon {
 	}
 	public get classNames() { return 'codicon codicon-' + this.id; }
 	public get cssSelector() { return '.codicon.codicon-' + this.id; }
-	public get iconClassName() { return 'codicon-' + this.id; }
 }
 
 interface IconDefinition {

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,6 @@ export class Codicon {`
`53`	`53`	`}`
`54`	`54`	`public get classNames() { return 'codicon codicon-' + this.id; }`
`55`	`55`	`public get cssSelector() { return '.codicon.codicon-' + this.id; }`
`56`		`- public get iconClassName() { return 'codicon-' + this.id; }`
`57`	`56`	`}`
`58`	`57`
`59`	`58`	`interface IconDefinition {`