GDPR comments

kieferrm · kieferrm · commit 7dc7165782a0 · 2017-09-25T18:36:43.000-07:00
diff --git a/src/vs/platform/telemetry/browser/errorTelemetry.ts b/src/vs/platform/telemetry/browser/errorTelemetry.ts
@@ -153,7 +153,7 @@ export default class ErrorTelemetry {
 				  "column": { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth" }
 			   }
 			 */
-			// __GDPR__TODO more properties are missing
+			// __GDPR__TODO what's the complete set of properties?
 			this._telemetryService.publicLog('UnhandledError', error);
 		}
 		this._buffer.length = 0;
diff --git a/src/vs/workbench/parts/debug/electron-browser/rawDebugSession.ts b/src/vs/workbench/parts/debug/electron-browser/rawDebugSession.ts
@@ -171,11 +171,7 @@ export class RawDebugSession extends V8Protocol implements debug.ISession {
 					 */
 					this.telemetryService.publicLog('debugProtocolErrorResponse', { error: telemetryMessage });
 					if (this.customTelemetryService) {
-						/* __GDPR__
-						   "debugProtocolErrorResponse" : {
-						   	"error" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" }
-						   }
-						*/
+						// __GDPR__TODO the message is sent in the name of the adapter but since the adapters are an open set, this can not be statically declared
 						this.customTelemetryService.publicLog('debugProtocolErrorResponse', { error: telemetryMessage });
 					}
 				}

Original file line number	Diff line number	Diff line change
`@@ -153,7 +153,7 @@ export default class ErrorTelemetry {`
`153`	`153`	`"column": { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth" }`
`154`	`154`	`}`
`155`	`155`	`*/`
`156`		`- // __GDPR__TODO more properties are missing`
	`156`	`+ // __GDPR__TODO what's the complete set of properties?`
`157`	`157`	`this._telemetryService.publicLog('UnhandledError', error);`
`158`	`158`	`}`
`159`	`159`	`this._buffer.length = 0;`
Original file line number	Diff line number	Diff line change
`@@ -171,11 +171,7 @@ export class RawDebugSession extends V8Protocol implements debug.ISession {`
`171`	`171`	`*/`
`172`	`172`	`this.telemetryService.publicLog('debugProtocolErrorResponse', { error: telemetryMessage });`
`173`	`173`	`if (this.customTelemetryService) {`
`174`		`- /* __GDPR__`
`175`		`- "debugProtocolErrorResponse" : {`
`176`		`- "error" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" }`
`177`		`- }`
`178`		`- */`
	`174`	`+ // __GDPR__TODO the message is sent in the name of the adapter but since the adapters are an open set, this can not be statically declared`
`179`	`175`	`this.customTelemetryService.publicLog('debugProtocolErrorResponse', { error: telemetryMessage });`
`180`	`176`	`}`
`181`	`177`	`}`